From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Avoid removing the display network when not defined
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/80393/1/lib/vdsm/virt/vmdevices/graphics.py
File lib/vdsm/virt/vmdevices/graphics.py:
Line 70: display_ip = '0'
Line 71: self.specParams['displayIp'] = display_ip
Line 72:
Line 73: def teardown(self):
Line 74: display_network = self.specParams['displayNetwork']
nice, more symmetrical vs setup()
Line 75: if display_network:
Line 76: libvirtnetwork.delete_network(display_network, self.vmid)
Line 77:
Line 78: def getSpiceVmcChannelsXML(self):
--
To view, visit https://gerrit.ovirt.org/80393
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd3faedd952a53bbd36a3e101079a65c8f6cf1ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80373 )
Change subject: ssl: handle handshake errors
......................................................................
ssl: handle handshake errors
A previous patch that handled the ssl hanshake errors was merged without
updating log entries for ssl errors.
We log now only the occurence of the error and the offending IP address
that caused the error.
We fix the issue by handling both errors and cleanly closing file
descriptor.
Change-Id: I2cc1d249b57d9893b3bc35dcf5d72674a83edf36
Bug-url: https://bugzilla.redhat.com/1473295
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/sslutils.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/80373
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cc1d249b57d9893b3bc35dcf5d72674a83edf36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: handle handshake errors
......................................................................
Patch Set 1:
you didn't use the right change-id I99cfa35e608f429640455c35495be1783854e3da :\
--
To view, visit https://gerrit.ovirt.org/80373
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc1d249b57d9893b3bc35dcf5d72674a83edf36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80339 )
Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces
......................................................................
net: Report empty LLDP TLV lists for operationally-down interfaces
Before this patch, a single interface that was never monitored by lldpad
had caused the API level to fail, blocking information about
properly-enabled interfaces.
This change reports interfaces being not in state UP as not
enabled for LLDP with an empty list of TLVs.
Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M lib/vdsm/network/lldp/info.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Dominik Holler: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80339
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/80339/6//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2017-08-08 11:09:22 +0200
Line 6:
Line 7: net: Report empty LLDP TLV lists for operationally-down interfaces
Line 8:
Line 9: Before this patch, a single interface never was monitored by lldpad
a single interface that was never monitored...
Line 10: had caused the API level to fail, blocking information about
Line 11: properly-enabled interfaces.
Line 12:
Line 13: This change reports interfaces being not in state UP as not
--
To view, visit https://gerrit.ovirt.org/80339
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80363 )
Change subject: m2cutils: support excluding OP_NO_TLSv1_2
......................................................................
m2cutils: support excluding OP_NO_TLSv1_2
OP_NO_TLSv1_2 constant is not supported by m2cutils.
Added the actual value conversion.
Label: ovirt-4.1-only
Bug-Url: https://bugzilla.redhat.com/1473344
Change-Id: I7f571f74486aa3974c53567d79a8441e9b157351
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/m2cutils.py
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80363
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f571f74486aa3974c53567d79a8441e9b157351
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>