From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Cleanup - Convert netconfpersistence._getConfigs to staticmethod
......................................................................
net: Cleanup - Convert netconfpersistence._getConfigs to staticmethod
Change-Id: Id85f8f17a1f7c111b435002d489addc431c0e0f6
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/netconfpersistence.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id85f8f17a1f7c111b435002d489addc431c0e0f6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Cleanup - Convert netconfpersistence._getConfigs to staticmethod
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id85f8f17a1f7c111b435002d489addc431c0e0f6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: network: paramsToBandwidthXML as staticmethod
......................................................................
vm: network: paramsToBandwidthXML as staticmethod
Since network.Interface.paramsToBandwidthXML use nothing of the
instance state, we turn it to a static method, and we rename it
to be pep8 friendlier.
No changes in behaviour.
Change-Id: Iaac88b4258cb5396e92631648af2b64a2350275c
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/network.py
M tests/device_test.py
M vdsm/virt/vm.py
3 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73275
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaac88b4258cb5396e92631648af2b64a2350275c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: network: paramsToBandwidthXML as staticmethod
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73275
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaac88b4258cb5396e92631648af2b64a2350275c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: func helpers, net: Cleanup oVirt Node reference
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/73609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32a9250a025fb0ed1a5c01027ff1503c6dad010b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: func helpers, net: Cleanup oVirt Node reference
......................................................................
Patch Set 2:
this is very much like the dormant https://gerrit.ovirt.org/#/c/68023/
code seems fine; the interesting bit is the verification.
--
To view, visit https://gerrit.ovirt.org/73609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32a9250a025fb0ed1a5c01027ff1503c6dad010b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: fix service_status in privileged containers
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/73251/1/lib/vdsm/tool/service.py
File lib/vdsm/tool/service.py:
Line 351: continue
Line 352: else:
Line 353: # BZ#1427527
Line 354: chroot_error = 'Running in chroot, ignoring request.' in err
Line 355: if rc == 0 and not chroot_error:
> which security permission did you set, and where?
running without systemd is something else and probably require to share different folders from the host to reach host's devices.. but to allow systemd as is to run in the container, I need to share /sys/fs/cgroup host's dir, and run with securityContext:privileged: true. I also set hostIPC: true, with that I didn't get this chroot issue. and I don't see host's network at all. vdsm service that runs there sees only the container's devices
Line 356: return 0
Line 357: else:
Line 358: raise ServiceOperationError(
Line 359: "%s failed" % alt.__name__, out, err)
--
To view, visit https://gerrit.ovirt.org/73251
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc0cb06142297468a660ebe9171c8dde4fd480a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec net: During VDSM upgrade, reset vdsm-network service
......................................................................
spec net: During VDSM upgrade, reset vdsm-network service
vdsm-network is a systemd oneshot service which should be reloaded upon
vdsm upgrade.
Currently it performs two actions:
- Triggers the upgrade-unified-persistence process.
- Restoration of the persisted networks.
Both are already "protected" by flags that assure they run only once per
boot, therefore no logic is suppose to be change with this path.
Future patches will introduce additional (or replacement) actions that
will leverage systemd oneshot semantics, instead of internal flag
implementations.
Change-Id: Ib574a89d33fafccf9f4ceca13ff9dae17f51dcf8
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73561
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib574a89d33fafccf9f4ceca13ff9dae17f51dcf8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tool: fix service_status in privileged containers
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/73251/1/lib/vdsm/tool/service.py
File lib/vdsm/tool/service.py:
Line 351: continue
Line 352: else:
Line 353: # BZ#1427527
Line 354: chroot_error = 'Running in chroot, ignoring request.' in err
Line 355: if rc == 0 and not chroot_error:
> I never got that when I set the right security permissions... for me it ret
which security permission did you set, and where?
We would like the networking code to run properly even if systemd is not running inside our container.
Line 356: return 0
Line 357: else:
Line 358: raise ServiceOperationError(
Line 359: "%s failed" % alt.__name__, out, err)
--
To view, visit https://gerrit.ovirt.org/73251
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc0cb06142297468a660ebe9171c8dde4fd480a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: add dhclient to dependencies
......................................................................
add dhclient to dependencies
While dhclient is usualy available in minimal server instalation,
it is not pre-installed inside container images.
Change-Id: If9c5479d84e41e6c085f973f152f7722370bcbf4
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73367
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9c5479d84e41e6c085f973f152f7722370bcbf4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: add dhclient to dependencies
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/73367
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9c5479d84e41e6c085f973f152f7722370bcbf4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: create supervdsm package
......................................................................
Patch Set 13: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/69079/13/configure.ac
File configure.ac:
Line 1: #
Line 2: # Copyright 2008-2016 Red Hat, Inc.
change to 2017
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
https://gerrit.ovirt.org/#/c/69079/13/lib/vdsm/gluster/api.py
File lib/vdsm/gluster/api.py:
Line 1: #
Line 2: # Copyright 2012-2016 Red Hat, Inc.
2017
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 27: from vdsm.common.define import doneCode
Line 28: from vdsm.gluster import exception as ge
Line 29: from vdsm.gluster import fstab
Line 30: from vdsm.storage import mount
Line 31: from vdsm.supervdsm import proxy as svdsm
svdsm is good. or you could just call the module sproxy instead of proxy
Line 32: from vdsm import constants
Line 33: from vdsm import commands
Line 34: from vdsm import utils
Line 35: from pwd import getpwnam
https://gerrit.ovirt.org/#/c/69079/13/lib/vdsm/host/caps.py
File lib/vdsm/host/caps.py:
Line 28:
Line 29: from vdsm.config import config
Line 30: from vdsm.host import rngsources
Line 31: from vdsm.storage import hba
Line 32: from vdsm.supervdsm import proxy
better to import that as supervdsm_proxy or something.. proxy is too general
Line 33: from vdsm import containersconnection
Line 34: from vdsm import cpuarch
Line 35: from vdsm import cpuinfo
Line 36: from vdsm import dsaversion
https://gerrit.ovirt.org/#/c/69079/13/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:
Line 1: #
Line 2: # Copyright 2014 Red Hat, Inc.
-2017
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
--
To view, visit https://gerrit.ovirt.org/69079
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05c9c21912bb4bf27b68db5d0d4affb0f5ac7e81
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: spec net: During VDSM upgrade, reset vdsm-network service
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/73561
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib574a89d33fafccf9f4ceca13ff9dae17f51dcf8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: add dhclient to dependencies
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73367
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9c5479d84e41e6c085f973f152f7722370bcbf4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Use netinfo iface users check version (instead of ifaceUsed)
......................................................................
net: Use netinfo iface users check version (instead of ifaceUsed)
Checking if an iface is used by other devices has two implementetions:
- Check against existing kernel config: ifaceUsed()
- Check against a given netinfo instance content: NetInfo.ifaceUsers()
Both are based on the kernel config with some specific differences:
- The first is directly checking against the kernel and includes a check
against libvirt for the network existance.
- The second is checking against netinfo content, which was previously
collected from the kernel and from libvirt for the networks.
Note: Networks as entities are collected by netinfo from libvirt at the
moment. NetInfo acts as an abstraction layer, allowing future patches
to change the source of the data without affecting its users.
Future patches will change the network data source from libvirt to
running config.
Change-Id: Ic6cb0c24c105ccf84f432f4e526206f6f9a48e09
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/configurators/qos.py
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/models.py
M lib/vdsm/network/netinfo/cache.py
5 files changed, 20 insertions(+), 11 deletions(-)
Approvals:
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved; Passed CI tests
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/72827
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6cb0c24c105ccf84f432f4e526206f6f9a48e09
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Push NetInfo object down the ifcfg setup flow
......................................................................
net: Push NetInfo object down the ifcfg setup flow
In this patch, the transaction NetInfo instance is pushed down through
the ifcfg configurator setup flow.
This patch is the first step to use NetInfo.ifaceUsers()
instead of ifaceUsed(), making NetInfo available where it is needed.
In the next patch ifaceUsed() is replaced by NetInfo.ifaceUsers()
Change-Id: Icddf479171b7a4d05ed803bd199831f59a7e9167
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/__init__.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/configurators/iproute2.py
M lib/vdsm/network/configurators/qos.py
M lib/vdsm/network/netswitch.py
M tests/network/config_network_test.py
6 files changed, 24 insertions(+), 20 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/72826
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icddf479171b7a4d05ed803bd199831f59a7e9167
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use netinfo iface users check version (instead of ifaceUsed)
......................................................................
Patch Set 9: Continuous-Integration+1
both passed (but jenkins restarted, so no score)
http://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/8037/http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc25-x86_64/2172/
--
To view, visit https://gerrit.ovirt.org/72827
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6cb0c24c105ccf84f432f4e526206f6f9a48e09
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use netinfo iface users check version (instead of ifaceUsed)
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72827
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6cb0c24c105ccf84f432f4e526206f6f9a48e09
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Push NetInfo object down the ifcfg setup flow
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72826
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icddf479171b7a4d05ed803bd199831f59a7e9167
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Normalize network 'ipv6addr' on netinfo to kconfig translation
......................................................................
net: Normalize network 'ipv6addr' on netinfo to kconfig translation
'ipv6addr' is being normalized on config read from a string to a list in
order to correctly compare it to kernelconfig.
It is more appropriate to perform the opposite translation, from netinfo
to the config representation.
Change-Id: Ifb1caec15d5193d272e179db6bb4e1aad8e6afc7
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/kernelconfig.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73245
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb1caec15d5193d272e179db6bb4e1aad8e6afc7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Normalize network 'ipv6addr' on netinfo to kconfig translation
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/73245/1/lib/vdsm/network/kernelconfig.py
File lib/vdsm/network/kernelconfig.py:
Line 101: attributes['netmask'] = net_attr['netmask']
Line 102: if net_attr['gateway']:
Line 103: attributes['gateway'] = net_attr['gateway']
Line 104: if not attributes['dhcpv6']:
Line 105: if net_attr['ipv6addrs']:
RunningConfig does not support multiple ipv6 addresses, but netinfo reports them. Choose random address and report it in KernelConfig
Line 106: # kernelconfig does not support multiple IPv6 addresses,
Line 107: # therefore a random one is chosen.
Line 108: attributes['ipv6addr'] = net_attr['ipv6addrs'][0]
Line 109: if net_attr['ipv6gateway'] != '::':
--
To view, visit https://gerrit.ovirt.org/73245
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb1caec15d5193d272e179db6bb4e1aad8e6afc7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: devices: rng: declare 'address' attribute
......................................................................
virt: devices: rng: declare 'address' attribute
since we redefine __slots__, we need to declare all the attributes
we use.
Change-Id: I1faae54e8a88d7e9c67eb35cd5e5de1eec21fd73
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/core.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/70927
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1faae54e8a88d7e9c67eb35cd5e5de1eec21fd73
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: devices: redir: declare the 'bus' attribute
......................................................................
virt: devices: redir: declare the 'bus' attribute
It was not included in __slots__, but we need it.
Change-Id: Ia36d1c38e466d4cf11312eb13b6d7be64fa37109
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/core.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72955
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia36d1c38e466d4cf11312eb13b6d7be64fa37109
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: redir: declare the 'bus' attribute
......................................................................
Patch Set 5: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/72955
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36d1c38e466d4cf11312eb13b6d7be64fa37109
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: rng: declare 'address' attribute
......................................................................
Patch Set 9: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/70927
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1faae54e8a88d7e9c67eb35cd5e5de1eec21fd73
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Run job completed actions after recovered migrations
......................................................................
virt: Run job completed actions after recovered migrations
VM.onJobCompleted checks self._migrationSourceThread.started flag to know
whether the callback was invoked after a migration. However if Vdsm was
restarted during the migration, the flag is not set since the source thread is
not actually running. So in such a case onJobCompleted returns immediately
without performing the post-migration actions.
We fix it by adding a check for a recovered migration at the place. We must
also ensure that SourceThread._recovery is reset after unsuccessful migration,
otherwise the post-migration actions would be called for all subsequent domain
jobs. This doesn't work in all situations since libvirt may not notify us
after failed migrations so SourceThread._recovery gets reset only when the
migration is explicitly canceled.
Change-Id: I2eaacbfc48bee4863ec75b29e120fc5aa7b31d10
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M lib/vdsm/virt/migration.py
M vdsm/virt/vm.py
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/73447
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2eaacbfc48bee4863ec75b29e120fc5aa7b31d10
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmxml: separate vmxml.Element and etree.Element
......................................................................
vmxml: separate vmxml.Element and etree.Element
Up until now, the vmxml.Element was quite liberal in accepting
arguments to its append*() methods; same was true for
vmxml.append_child.
We had freedom to mix and match vmxml.Element and etree.Elements
freely, without any apparent harm.
Things change in python3; if we run the very same code under python3,
for example because of the tests introduced in
patch Id1beb214e76c5173de318406fc6208990d33adbb
we get errors like
File "lib/vdsm/virt/vmxml.py", line 334, in appendChild
self._elem.append(element)
TypeError: append() argument must be xml.etree.ElementTree.Element, not Element
To fix this issue, we must always append etree Elements childs.
Confusion can arise from a couple od sources; we add a special-purpose
appendEtree method to mark such places, in order to always append
the right element.
Change-Id: I60003e69702508e173703fcfa7d5ec2e0cffbd14
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/libvirtxml.py
M lib/vdsm/virt/vmdevices/network.py
M lib/vdsm/virt/vmxml.py
M tests/vmxml_test.py
4 files changed, 34 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60003e69702508e173703fcfa7d5ec2e0cffbd14
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vmxml: separate vmxml.Element and etree.Element
......................................................................
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60003e69702508e173703fcfa7d5ec2e0cffbd14
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Properly initialize ConfigNetworkError exception
......................................................................
net: Properly initialize ConfigNetworkError exception
Change-Id: I75e0979412b9d8baba2e6c18c3f19d70f827b075
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/errors.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75e0979412b9d8baba2e6c18c3f19d70f827b075
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Properly initialize ConfigNetworkError exception
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75e0979412b9d8baba2e6c18c3f19d70f827b075
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: migrating testSetupNetworksAddManyVlans to the new func tests
......................................................................
net tests: migrating testSetupNetworksAddManyVlans to the new func tests
Change-Id: I21418bc9b094ecfbc17cfbe5df9414ecfbac18f8
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/functional/networkTests.py
M tests/network/func_net_basic_test.py
2 files changed, 25 insertions(+), 31 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73243
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21418bc9b094ecfbc17cfbe5df9414ecfbac18f8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: migrating testSetupNetworksAddManyVlans to the new func tests
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73243
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21418bc9b094ecfbc17cfbe5df9414ecfbac18f8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sr-iov: expose numa_node if available
......................................................................
sr-iov: expose numa_node if available
VDSM tries to find the best numa node for VM if host device exists.
Since the whole point of that feature is to eventually be available
for SR-IOV, Interface class should also expose it's numa_node.
Side effect is that since the code is checking *all* hostdevices
(including SR-IOV), using sr-iov+hostdev currently doesn't work.
Change-Id: I53094f8399d200b4dc92afb29f1c8ef9f8f47495
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1427202
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/network.py
M tests/device_test.py
2 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/73162
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53094f8399d200b4dc92afb29f1c8ef9f8f47495
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: remove is_hostdevice from __slots__
......................................................................
network: remove is_hostdevice from __slots__
Already implemented by core.Base, doesn't need to be reimplemented.
Change-Id: I19b2eeda1e76c1076a9ecfd0945393c162a6148e
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/network.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/73232
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19b2eeda1e76c1076a9ecfd0945393c162a6148e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: Add grace/synchronization period for mode4 bonds.
......................................................................
net tests: Add grace/synchronization period for mode4 bonds.
Although mode 4 bonds may be reported up, they may still not be fully
synchronized with their partner bond. The rate in which dedicated
packets are sent to the slaves is set/determined via the "lp_interval"
option -- wait the interval and some predetermined grace period to allow
the bonds to become synchronized with their partner bonds.
Change-Id: I70ad2e8fbf2b54971eba79f8de44e199e54ae4e3
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 21 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70ad2e8fbf2b54971eba79f8de44e199e54ae4e3
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Add grace/synchronization period for mode4 bonds.
......................................................................
Patch Set 23: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70ad2e8fbf2b54971eba79f8de44e199e54ae4e3
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Add grace/synchronization period for mode4 bonds.
......................................................................
Patch Set 22: Code-Review-1
manual rebase required
--
To view, visit https://gerrit.ovirt.org/73042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70ad2e8fbf2b54971eba79f8de44e199e54ae4e3
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Limit migration recovery status to previously migrating VMs
......................................................................
virt: Limit migration recovery status to previously migrating VMs
We introduced a check for running migrations in recovery. We utilize
migration.ongoing function for the check.
However migration.ongoing assumes that the domain has already been migrating to
another host, it doesn't work correctly in the general case, when we don't know
anything about the VM migration status in advance. The migration.ongoing check
is based on checking the presence of a domain job since there is no much better
way to check for ongoing migrations in libvirt. However the domain jobs are
not limited to host-to-host migrations, they can perform other tasks such as
hibernation or making a snapshot.
To satisfy the assumption of migration.ongoing we check for MIGRATION_SOURCE
status in recovery.
Change-Id: I37ce91f9490206fe2c68504dd17aa4326764d6ed
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/72703
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37ce91f9490206fe2c68504dd17aa4326764d6ed
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm-client: add help message per namespace
......................................................................
vdsm-client: add help message per namespace
help message is now generated from vdsm schema
and provides information for constructing a command.
vdsm-client -h
usage: vdsm-client [-h] [-a HOST] [-p PORT] [--unsecure] [--timeout TIMEOUT]
[-f FILE]
namespace method [arg=value] ...
Namespaces:
namespace method [arg=value]
Host
Task
LVMVolumeGroup
Image
VM
Volume
StorageDomain
ISCSIConnection
StoragePool
SDM
Lease
vdsm-client Lease -h
usage: vdsm-client Lease [-h] method [arg=value] ...
optional arguments:
-h, --help show this help message and exit
Lease methods:
method [arg=value]
rebuild_leases Rebuild external leases index on storage domain
status Return the underlying sanlock lease status
info Return external lease information
delete Delete an external lease (only on the SPM host)
create Create an external lease (only on the SPM host)
vdsm-client Lease create -h
usage: vdsm-client Lease create [-h] [arg=value [arg=value ...]]
positional arguments:
arg=value lease: The lease to create
JSON representation:
{
"lease": {
"sd_id": "UUID",
"lease_id": "UUID"
}
}
optional arguments:
-h, --help show this help message and exit
Change-Id: Ia9a8a605394e21fe5cbb7c3ddbe67d07a7da0f5c
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsmclient/client.py
1 file changed, 61 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/68101
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9a8a605394e21fe5cbb7c3ddbe67d07a7da0f5c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: fix service_status in privileged containers
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/73251/1/lib/vdsm/tool/service.py
File lib/vdsm/tool/service.py:
Line 351: continue
Line 352: else:
Line 353: # BZ#1427527
Line 354: chroot_error = 'Running in chroot, ignoring request.' in err
Line 355: if rc == 0 and not chroot_error:
I never got that when I set the right security permissions... for me it returns the same output as running systemd on any system
Line 356: return 0
Line 357: else:
Line 358: raise ServiceOperationError(
Line 359: "%s failed" % alt.__name__, out, err)
--
To view, visit https://gerrit.ovirt.org/73251
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc0cb06142297468a660ebe9171c8dde4fd480a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsmapi: get complex type representation
......................................................................
vdsmapi: get complex type representation
vdsm-api contain some complex method prameter types.
vdsm-client should use vdsmapi.py knowledge of the schema
in order to help the users construct these parameters.
vdsmapi now returns a dictionary represenation of
given command parameters.
keys represent the parameter names and dict values are
the parameter types.
Note that it's almost perfect: union types aren't fully
represented and only the union types are being stored.
usage:
from vdsm.api import vdsmapi
schema_paths = [vdsmapi.find_schema()]
schema = vdsmapi.Schema(schema_paths, False)
schema.get_args_dict("Lease", "create")
{
"lease": {
"sd_id": "UUID",
"lease_id": "UUID"
}
}
Change-Id: I25a9ace931b377408ffabb2b570af9da7cfccfc6
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/api/vdsmapi.py
M tests/vdsmapi_test.py
2 files changed, 112 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/73172
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25a9ace931b377408ffabb2b570af9da7cfccfc6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: prevent importing of VMware VMs with snapshot
......................................................................
v2v: prevent importing of VMware VMs with snapshot
Since v2v doesn't support importing of VMs with snapshot(s), then we need
to avoid importing those VMs.
Since for Xen there is no libvirt API implemented for checking if
snapshots exist and for 'OVA from VMware' and KVM - the VM is imported
after all snapshots are collapsed, then the only external provider left
to handle is VMware.
Before this fix, trying to import a VMware VM with snapshot caused the import
to fail while trying to locate the current snapshot delta invalid vmdk disk name for
copying.
This solution handle this by skipping those VMS and writing an error to log.
Skipping means avoid sending the full info (XML, disks, network info etc) on those
VMs to the engine and therefore avoid displaying them in v2v second dialog
for importing.
Change-Id: Ic88a918aac2a1943aad8f6cf0a67daf5f2f9accc
Bug-Url: https://bugzilla.redhat.com/1336840
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M lib/vdsm/v2v.py
M tests/v2v_test.py
M tests/v2v_testlib.py
3 files changed, 34 insertions(+), 8 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
Francesco Romani: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/72720
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic88a918aac2a1943aad8f6cf0a67daf5f2f9accc
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Remove ipv4 prefix normalization from kernelconfig
......................................................................
net: Remove ipv4 prefix normalization from kernelconfig
IPv4 prefix normalization is already performed at the canonicalize step,
there is no need to do it at kernelconfig normalization.
It is not expected for both netmask and prefix to exist in the
configuration and with this patch we embrace the canonicalize logic of
failing when both exists.
Change-Id: Ia3c5f9ee1c84d0113d2ecb3e2055785f7290f8b6
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/canonicalize.py
M lib/vdsm/network/kernelconfig.py
2 files changed, 2 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3c5f9ee1c84d0113d2ecb3e2055785f7290f8b6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Move bond slaves normalization to canonicalize step
......................................................................
net: Move bond slaves normalization to canonicalize step
Change-Id: I9e98c7c8907cb379fd0728a397e15d8fe03df464
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/canonicalize.py
M lib/vdsm/network/kernelconfig.py
2 files changed, 6 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73183
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e98c7c8907cb379fd0728a397e15d8fe03df464
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Cleanup unused config net attrs filter fields
......................................................................
net: Cleanup unused config net attrs filter fields
When adding a network to a config (running/persistent), some fields have
been filtered out. This a hack used to adjust the code to the caller
usage.
This patch removes fields that are no longer in use by the callers,
therefore there is no need to filter them out.
Change-Id: I84f88d79cfa152f548334e6d3aed0d983999eb75
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/netconfpersistence.py
1 file changed, 8 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73105
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84f88d79cfa152f548334e6d3aed0d983999eb75
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Move dhcp config normalization to canonicalize step
......................................................................
net: Move dhcp config normalization to canonicalize step
Change-Id: Iad3cc1a0d7c06fc33b6c4c0526459e9e2516b2bd
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/canonicalize.py
M lib/vdsm/network/kernelconfig.py
2 files changed, 6 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73159
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad3cc1a0d7c06fc33b6c4c0526459e9e2516b2bd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: On rollback failure clean running config from removed nets
......................................................................
net: On rollback failure clean running config from removed nets
When a setup failure occurs during rollback, some networks may have been
already removed, therefore, this state needs to be expressed in the
persisted running config.
Change-Id: I90866aac87d22745347a711de1fe1c540724fee7
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/__init__.py
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73132
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90866aac87d22745347a711de1fe1c540724fee7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Drop blockingdhcp persistent config on read and write
......................................................................
net: Drop blockingdhcp persistent config on read and write
The blockingdhcp network attribute is used to request a specific setup
implementation behaviour: to block (or not) on a dhcp request.
This behaviour attribute is supose to be volatile, not saved in any
persistent config.
In this patch, attribute filtering is performed to filter out volatile
attributes (blockingdhcp at the moment) on config write and on config read.
Replacing the previous normalize blockingdhcp filtering.
Change-Id: I7ad81ba1d342db2ed560e95c79e5e96ca3da918c
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/kernelconfig.py
M lib/vdsm/network/netconfpersistence.py
M tests/functional/networkTests.py
3 files changed, 22 insertions(+), 28 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ad81ba1d342db2ed560e95c79e5e96ca3da918c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-client: add help message per namespace
......................................................................
Patch Set 8: Code-Review+1
looks really useful ... I wonder if we can separate it to generic jsonapi client base on our schema structure. later every component can deliver this client utility only by composing schema for its api in our format. classic open-source python infra
--
To view, visit https://gerrit.ovirt.org/68101
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a8a605394e21fe5cbb7c3ddbe67d07a7da0f5c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Remove ipv4 prefix normalization from kernelconfig
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3c5f9ee1c84d0113d2ecb3e2055785f7290f8b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Move bond slaves normalization to canonicalize step
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73183
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e98c7c8907cb379fd0728a397e15d8fe03df464
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Move dhcp config normalization to canonicalize step
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73159
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad3cc1a0d7c06fc33b6c4c0526459e9e2516b2bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Drop blockingdhcp persistent config on read and write
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad81ba1d342db2ed560e95c79e5e96ca3da918c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: On rollback failure clean running config from removed nets
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73132
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90866aac87d22745347a711de1fe1c540724fee7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Cleanup unused config net attrs filter fields
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73105
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84f88d79cfa152f548334e6d3aed0d983999eb75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: osinfo: show variant name in osname for ngn hosts
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/73403/2//COMMIT_MSG
Commit Message:
Line 7: osinfo: show variant name in osname for ngn hosts
Line 8:
Line 9: Currently, vdsm provides OS name for NGN hosts incorrectly, i.e:
Line 10: it shows RHVH node as RHEL node, which may lead users to confusion
Line 11: when visualizating OS data in Engine GUI. This patch adds variant
> I have provided the output in the comments. No, nothing broken, just used t
please add the example in the commit message. The text of the message is not clear to me.
And yes, the bug is about failed migration. if this is something else, please use a different bug.
Line 12: name as osname for ngn hosts.
Line 13:
Line 14: Change-Id: I2253e0ba9c3bec8e3c02a9197d3fc8b1fc11ade6
Line 15: Bug-Url: https://bugzilla.redhat.com/1425174
--
To view, visit https://gerrit.ovirt.org/73403
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2253e0ba9c3bec8e3c02a9197d3fc8b1fc11ade6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mailbox: Add tests for mailbox validation
......................................................................
mailbox: Add tests for mailbox validation
When SPM mailbox is reading new mail, it validates the mailbox checksum.
Add tests before modifying this code.
Change-Id: I4ec15704cc913777b5bf9dd8bd983cdec6336673
Bug-Url: https://bugzilla.redhat.com/1426762
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M lib/vdsm/storage/mailbox.py
M tests/storage_mailbox_test.py
2 files changed, 32 insertions(+), 2 deletions(-)
Approvals:
Adam Litke: Looks good to me, approved
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73077
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ec15704cc913777b5bf9dd8bd983cdec6336673
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Add grace/synchronization period for mode4 bonds.
......................................................................
Patch Set 22: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/73042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70ad2e8fbf2b54971eba79f8de44e199e54ae4e3
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: osinfo: show variant name in osname for ngn hosts
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/73403/2//COMMIT_MSG
Commit Message:
Line 7: osinfo: show variant name in osname for ngn hosts
Line 8:
Line 9: Currently, vdsm provides OS name for NGN hosts incorrectly, i.e:
Line 10: it shows RHVH node as RHEL node, which may lead users to confusion
Line 11: when visualizating OS data in Engine GUI. This patch adds variant
what is the output before and after this patch, on RHVH and on RHEL?
Is it really related to the cited bug? Is migration broken without it?
Line 12: name as osname for ngn hosts.
Line 13:
Line 14: Change-Id: I2253e0ba9c3bec8e3c02a9197d3fc8b1fc11ade6
Line 15: Bug-Url: https://bugzilla.redhat.com/1425174
--
To view, visit https://gerrit.ovirt.org/73403
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2253e0ba9c3bec8e3c02a9197d3fc8b1fc11ade6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: contrib: configurable VDSM_DIR in shell_helper
......................................................................
Patch Set 3: -Code-Review
--
To view, visit https://gerrit.ovirt.org/73129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8db64d3aaa2269ceeb046cc0b6448e0166e2cecb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: move QCOW2 setting to vminfo
......................................................................
v2v: move QCOW2 setting to vminfo
patch I846e75e6292c0b249e66b08ceec6b371e9b50f22 added ability for
setting QCOW2 version while importing by adding a new parameter version
to the api.
This change require the engine to have two signatures of
convertExternalVm and convertExternalVmFromOva verbs for backward
compatibility.
moving the setting to the vminfo structure will leave the api as is and
will not require handling of backward compatibility.
Change-Id: I7eb649b92e646d457d77c822ce1000fde09995c8
Bug-Url: https://bugzilla.redhat.com/1412451
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M lib/vdsm/api/vdsm-api.yml
M lib/vdsm/v2v.py
M tests/v2v_test.py
M vdsm/API.py
4 files changed, 35 insertions(+), 50 deletions(-)
Approvals:
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71665
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7eb649b92e646d457d77c822ce1000fde09995c8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: schema: add new type ExternalVmParams and ExternalDiskParams
......................................................................
schema: add new type ExternalVmParams and ExternalDiskParams
currently v2v use ExternalVmInfo and ExternalDiskInfo for all the
getExternalVm* methods and for all the convertVm* methods.
convertVm* uses other values that the engine changes so adding a new
type ExternalVmParams and ExternalDiskParams for all the convertVm* methods.
Change-Id: Id310093339548f72a1ed8747df879217b5784cf3
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M lib/vdsm/api/vdsm-api.yml
1 file changed, 56 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71879
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id310093339548f72a1ed8747df879217b5784cf3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: contrib: configurable VDSM_DIR in shell_helper
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8db64d3aaa2269ceeb046cc0b6448e0166e2cecb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: remove Node reference
......................................................................
network: remove Node reference
Change-Id: I1f973d949daa8b3d9a30d45761a6b77aaa579528
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
---
M lib/vdsm/network/netconfpersistence.py
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72511
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f973d949daa8b3d9a30d45761a6b77aaa579528
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: remove Node reference
......................................................................
Patch Set 1: Code-Review+2 Verified+1
comment removal, no need in v+1.
--
To view, visit https://gerrit.ovirt.org/72511
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f973d949daa8b3d9a30d45761a6b77aaa579528
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: add missing gluster exception
......................................................................
gluster: add missing gluster exception
GlusterHostStorageDeviceMkfsFailedException is missing in
gluster/exception.py and wrong arugments are passed in
gluster/storagedev.py. This patche adds the missing exception \
and corrects the arguments passed.
Change-Id: I86c396bc7f80ea3cf60056db6010ccc7b0c172f9
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M lib/vdsm/gluster/exception.py
M lib/vdsm/gluster/storagedev.py
2 files changed, 9 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Sahina Bose: Looks good to me, but someone else must approve
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/73171
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86c396bc7f80ea3cf60056db6010ccc7b0c172f9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: correct exception name in gluster/cli.py
......................................................................
gluster: correct exception name in gluster/cli.py
cli.py is referring to a non existant exception
GlusterXmlErrorInfoException. It should be GlusterXmlErrorException.
Change-Id: Iddc63f1fd100d33c7db541c8d2150f9e366e2491
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M lib/vdsm/gluster/cli.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/73170
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddc63f1fd100d33c7db541c8d2150f9e366e2491
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vmxml: separate vmxml.Element and etree.Element
......................................................................
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/72089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60003e69702508e173703fcfa7d5ec2e0cffbd14
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ngn: grab OS version according with /etc/os-release
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73297
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: adding handling for NGN in osinfo.py
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73298
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida119527b263302bf3f78e359bac12113718b744
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-HasComments: No