From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Limit migration recovery status to previously migrating VMs
......................................................................
virt: Limit migration recovery status to previously migrating VMs
We introduced a check for running migrations in recovery. We utilize
migration.ongoing function for the check.
However migration.ongoing assumes that the domain has already been migrating to
another host, it doesn't work correctly in the general case, when we don't know
anything about the VM migration status in advance. The migration.ongoing check
is based on checking the presence of a domain job since there is no much better
way to check for ongoing migrations in libvirt. However the domain jobs are
not limited to host-to-host migrations, they can perform other tasks such as
hibernation or making a snapshot.
To satisfy the assumption of migration.ongoing we check for MIGRATION_SOURCE
status in recovery.
Change-Id: I37ce91f9490206fe2c68504dd17aa4326764d6ed
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit
https://gerrit.ovirt.org/72703
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37ce91f9490206fe2c68504dd17aa4326764d6ed
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>