From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Remove ipv4 prefix normalization from kernelconfig
......................................................................
net: Remove ipv4 prefix normalization from kernelconfig
IPv4 prefix normalization is already performed at the canonicalize step,
there is no need to do it at kernelconfig normalization.
It is not expected for both netmask and prefix to exist in the
configuration and with this patch we embrace the canonicalize logic of
failing when both exists.
Change-Id: Ia3c5f9ee1c84d0113d2ecb3e2055785f7290f8b6
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/canonicalize.py
M lib/vdsm/network/kernelconfig.py
2 files changed, 2 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit
https://gerrit.ovirt.org/73194
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3c5f9ee1c84d0113d2ecb3e2055785f7290f8b6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>