From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: move QCOW2 setting to vminfo
......................................................................
v2v: move QCOW2 setting to vminfo
patch I846e75e6292c0b249e66b08ceec6b371e9b50f22 added ability for
setting QCOW2 version while importing by adding a new parameter version
to the api.
This change require the engine to have two signatures of
convertExternalVm and convertExternalVmFromOva verbs for backward
compatibility.
moving the setting to the vminfo structure will leave the api as is and
will not require handling of backward compatibility.
Change-Id: I7eb649b92e646d457d77c822ce1000fde09995c8
Bug-Url:
https://bugzilla.redhat.com/1412451
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M lib/vdsm/api/vdsm-api.yml
M lib/vdsm/v2v.py
M tests/v2v_test.py
M vdsm/API.py
4 files changed, 35 insertions(+), 50 deletions(-)
Approvals:
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/71665
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7eb649b92e646d457d77c822ce1000fde09995c8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>