From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: prevent importing of VMware VMs with snapshot
......................................................................
v2v: prevent importing of VMware VMs with snapshot
Since v2v doesn't support importing of VMs with snapshot(s), then we need
to avoid importing those VMs.
Since for Xen there is no libvirt API implemented for checking if
snapshots exist and for 'OVA from VMware' and KVM - the VM is imported
after all snapshots are collapsed, then the only external provider left
to handle is VMware.
Before this fix, trying to import a VMware VM with snapshot caused the import
to fail while trying to locate the current snapshot delta invalid vmdk disk name for
copying.
This solution handle this by skipping those VMS and writing an error to log.
Skipping means avoid sending the full info (XML, disks, network info etc) on those
VMs to the engine and therefore avoid displaying them in v2v second dialog
for importing.
Change-Id: Ic88a918aac2a1943aad8f6cf0a67daf5f2f9accc
Bug-Url:
https://bugzilla.redhat.com/1336840
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M lib/vdsm/v2v.py
M tests/v2v_test.py
M tests/v2v_testlib.py
3 files changed, 34 insertions(+), 8 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
Francesco Romani: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/72720
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic88a918aac2a1943aad8f6cf0a67daf5f2f9accc
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>