sinnykumari opened a new pull-request against the project: `releng` that you are following: `` Update atomic.twoweek fedmsg with multi-arch content ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` typo: information ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` we need to verify this library is installed on the machine we run this on ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` For first time readers of the code it would be nice to get an "example" of what this dict will look like and the information it will contain ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` i.e. since this dict is essentially what gets sent out in the fedmsg. Also do we need to update any fedmsg docs with an example of what the new fedmsg will look like? ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` a few comments.. mostly LGTM ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
sinnykumari commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` Right! I will check into ansible repo. Just to confirm this twoweek script runs on machine bodhi-backend01.phx2.fedoraproject.org , right? ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
sinnykumari commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` We may need to update fedmsg doc at http://fedora-fedmsg.readthedocs.io/en/latest/topics.html#releng. Also, updating sop wiki https://docs.pagure.org/releng/sop_two_week_atomic.html will be needed. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` yeah according to the SOP it's `bodhi-backend01.phx2.fedoraproject.org` ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
sinnykumari commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` Thanks @dustymabe for the review
I have made required fixes as per review comments which are related to twoweek script.
I will be working separately on updating fedmsg doc. By looking into ansible repo, it looks to me that fedfind is not installed in bodhi-backend01.phx2.fedoraproject.org machine. Will also work on getting fedfind added on host. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` I actually wouldn't mind just copying that content here. We can trim some of it:
``` "msg": { "aarch64": { "atomic_dvd_ostree": { "name": "Fedora-AtomicHost-ostree-aarch64-28-20180515.1.iso", "image_name": "Fedora-AtomicHost-ostree-aarch64-28-20180515.1.iso", "image_url": "/pub/alt/atomic/stable/Fedora-Atomic-28-20180515.1/AtomicHost/aarch64/iso/Fedora-AtomicHost-ostree-aarch64-28-20180515.1.iso", "release": "28", "compose_id": "Fedora-Atomic-28-20180515.1", "size": 988649472 }, "atomic_qcow2": { "name": "Fedora-AtomicHost-28-20180515.1", "image_name": "Fedora-AtomicHost-28-20180515.1.aarch64.qcow2", "image_url": "/pub/alt/atomic/stable/Fedora-Atomic-28-20180515.1/AtomicHost/aarch64/images/Fedora-AtomicHost-28-20180515.1.aarch64.qcow2", "release": "28", "compose_id": "Fedora-Atomic-28-20180515.1", "size": 621911040 }, "atomic_raw": { "name": "Fedora-AtomicHost-28-20180515.1", "image_name": "Fedora-AtomicHost-28-20180515.1.aarch64.raw.xz", "image_url": "/pub/alt/atomic/stable/Fedora-Atomic-28-20180515.1/AtomicHost/aarch64/images/Fedora-AtomicHost-28-20180515.1.aarch64.raw.xz", "release": "28", "compose_id": "Fedora-Atomic-28-20180515.1", "size": 396619232 } }, "x86_64": { ... }, "ppc64le": { ... } } ``` ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` can we add a 2nd commit that deletes `MARK_ATOMIC_HOST_BAD` code? I really don't think we use that any longer? ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
sinnykumari commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: ``
can we add a 2nd commit that deletes MARK_ATOMIC_HOST_BAD code? I really don't think we use that any longer?
I will do a separate PR for it. I felt that few more clean-ups can be done but I was afraid to touch them in case it breaks something I am not aware of :) ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
sinnykumari commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` I tried to put something like this in comment with trimming of stuff and then It looked to me a bit of lengthy comment and hence I just added the link. If we are ok with this comment, will add it. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` yeah I like having it inline - that way it can be updated if things change. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: ``
I will do a separate PR for it.
+1 ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
sinnykumari commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` Added dict structure in inline comment ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` LGTM. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
mohanboddu commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` LGTM +1 ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
mohanboddu commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` Also as @dustymabe mentioned earlier, fedfind is not installed on bodhi-backend01 from which we run the two week release.
So, we need to work with infra to get it installed. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: ``
Also as @dustymabe mentioned earlier, fedfind is not installed on bodhi-backend01 from which we run the two week release. So, we need to work with infra to get it installed.
@sinnykumari has taken that as an action item. She will open a ticket to make it happen. I'm going to go ahead and merge this. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
dustymabe merged a pull-request against the project: `releng` that you are following.
Merged pull-request:
`` Update atomic.twoweek fedmsg with multi-arch content ``
mohanboddu commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` @dustymabe Sounds good. Thanks @sinnykumari ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
sinnykumari commented on the pull-request: `Update atomic.twoweek fedmsg with multi-arch content` that you are following: `` Infra ticket - https://pagure.io/fedora-infrastructure/issue/7001 ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/pull-request/7519
rel-eng@lists.fedoraproject.org