[releng] Issue #7300: Deny push / Implement git hook for unescaped macro in %changelog - rel-eng - Fedora mailing-lists

9 Feb 2018


      ignatenkobrain reported a new issue against the project: `releng` that you are following:
``
```python
#!/usr/bin/python3
import re
import sys
replace = False
out = []
with open(sys.argv[1], "r"):
    for l in open(sys.argv[1], "r"):
        out.append(l)
        if l.startswith("%changelog"):
            replace = True
            continue
        if not replace:
            continue
        if l.startswith("%"):
            replace = False
            continue
        if l.startswith("*"):
            # XXX: HACK
            continue
        out[-1] = re.sub(r"([^%])%([^% \n\d])", r"\1%%\2", l)
with open(sys.argv[1], "w") as f:
    f.writelines(out)
```
This is something I've been using for automatic fix myself. I think we should either prohibit pushing this or have git-hook which would fix it automatically.
``
To reply, visit the link below or just reply to this email
https://pagure.io/releng/issue/7300