On Fri, May 08, 2015 at 11:13:19AM -0400, Stephen Gallagher wrote:
> and update places which use $PRETTY_NAME to use "$PRETTY
NAME
> ($VARIANT)" instead if appropriate? (Because in some cases the
> non-specific pretty name might be more appropriate.)
>
For the record, while /etc/os-release is meant to be source-able into
a Bourne-compatible shell, it's at the very least frowned upon for it
to have any variable substitutions in it. So let's please not do
that.
Oh, sorry — I was using that as shorthand for actually making those
substitions for the appropriate value, not for introducing variables
into the value themselves. I was going to mention that but forgot. :)
If we chose to do something like this, it should use literal values,
not the substitutions (It was unclear if that was what you were
saying).
So
PRETTY_NAME="Fedora 23 (Server Edition)"
I was asking about that vs
PRETTY_NAME="Fedora 23"
leaving out the () part, but then altering things like /etc/issue to
combine that with VARIANT. I dunno, it sounds like a bad idea now. :)
That's a question with more to it than you might think. Based on
the
way we're creating the os-release file, if a spin wanted to have a
different VARIANT and VARIANT_ID, it would need to ship a
spin-specific fedora-release-$SPIN package containing this os-release
file.
*nod*
The only reason to have VARIANTs defined here are for divergent
configuration defaults, which we've previously asserted is only
permissible with WG or FESCo permission, which is less likely for
most spins. (I could see some of the more well-maintained spins like
KDE possibly making such a request).
Right, that's specifically what I'm thinking. But, also, they might
find a distinct PRETTY_NAME valuable in its own right.
I'd say that spins should not set this value unless they have
been
granted permission by FESCo and at that point we should extend the
fedora-release package to produce a fedora-release-$SPIN subpackage
for them that handles this. I don't want us handing out permission to
generate os-release willy-nilly or it devalues os-release.
Makes sense.
--
Matthew Miller
<mattdm(a)fedoraproject.org>
Fedora Project Leader