mattdm reported a new issue against the project: `releng` that you are following: `` Proposed change: https://fedoraproject.org/wiki/Changes/Label_Our_Variants
Right now, we have `-atomichost`, `-cloud`, `-server`, and `-workstation`. This change would add:
-container -kdeplasma -xfce -mate-compiz -cinnamon -lxde -soas -silverblue
and possibly also
-astronomy -designsuite -games -jam -pythonclassroom -roboticssuite -scientific -securitylab ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
kellin added a new comment to an issue you are following: `` @mattdm I am wondering about these changes in light of the deliverables list that I am automating.
For example here is Workstation today:
VARIANT="Workstation Edition" VARIANT_ID=workstation
How would JAM (which is a Lab variant today) or Astronomy in the above?
I basically want to be sure that what we call things remains consistent. I've been talking to @mohanboddu about some of this already because a couple of our deliverables don't have a user-friendly name by default - and I'd want our names to be consistent product-wide. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
mattdm added a new comment to an issue you are following: `` "Jam" is kind of the most awkward example, but I would expect that this would look like:
PRETTY_NAME="Fedora 29 (Jam)" VARIANT="Jam" VARIANT_ID=jam
Robotics Suite would look like:
PRETTY_NAME="Fedora 29 (Robotics Suite)" VARIANT="Robotics Suite" VARIANT_ID=robotics-suite
and the KDE Plasma Desktop would look like:
PRETTY_NAME="Fedora 29 (KDE Plasma Desktop)" VARIANT="KDE Plasma Desktop" VARIANT_ID=kde-plasma-desktop
(or maybe `VARIANT_ID=kde-plasma`).
As we discussed in person, I don't think it's needed to keep straight whether something is a Lab or a Spin at the os-release file level. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
kellin added a new comment to an issue you are following: `` Releng acknowledges this change.
We will update Fedora Release package to support it. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
mattdm added a new comment to an issue you are following: `` Awesome! I was looking at doing it myself in https://pagure.io/fork/mattdm/fedora-release, but got bogged down with the kinda-crazy lua. It's a bit frustrating because there's a lot of repetition, but _so many_ special cases. For example, Atomic Host has packagename `fedora-release-atomichost`, but `VARIANT_ID` of `atomic.host` (with a `.`). Server and Workstation have special cases in the `%post` script. Etc.
``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
mattdm added a new comment to an issue you are following: `` @kellin Did you get a chance to work on this, or do you want to kick it back to me? ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
pbrobinson added a new comment to an issue you are following: `` @mattdm I can give a hand, I'm doing a bunch of other changes around here too ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
mattdm added a new comment to an issue you are following: `` @pbroboinson That would be awesome. As I mentioned above, I had gotten started on it myself, and then got over-ambitious trying to clean up the lua, and made the whole thing worse. I think it's probably best for this go-round to just live with a lot of copy-pasted code, because there are two many little fiddly variations to neatly organize everything into reusable functions. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
dustymabe added a new comment to an issue you are following: `` @pbrobinson ^^ ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
pbrobinson added a new comment to an issue you are following: `` @mattdm I'm working to get the tarfile bits merged in and once that's landed I'll do the changes on top of that and submit a PR for all to review there. I think the lua improvements can be on top of that. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
mattdm added a new comment to an issue you are following: `` Thanks @pbrobinson — and @dustymabe for the typo correction :) ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
The issue: `New variant subpackages for fedora-release` of project: `releng` has been assigned to `pbrobinson` by syeghiay.
syeghiay added a new comment to an issue you are following: `` @pbrobinson , will this make Beta Freeze on Aug 28? Please advise. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
mattdm added a new comment to an issue you are following: `` I have a PR at https://src.fedoraproject.org/rpms/fedora-release/pull-request/20
Note that I've built these and they seem to be Fine™ but I haven't actually installed them on any spins.
@mohanboddu ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
The issue: `New variant subpackages for fedora-release` of project: `releng` has been reset by pbrobinson.
The issue: `New variant subpackages for fedora-release` of project: `releng` has been assigned to `mattdm` by pbrobinson.
pbrobinson added a new comment to an issue you are following: ``
@pbrobinson , will this make Beta Freeze on Aug 28? Please advise.
_PLEASE_ read the feature owner, I offered to help out, not do all the work! ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
mattdm added a new comment to an issue you are following: `` To answer the question, yeah, I think it will be ready, although just barely, and variants may need freeze exceptions to add the packages, which was not my intention. (But my fault, so, there we go.) ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
The status of the issue: `New variant subpackages for fedora-release` of project: `releng` has been updated to: Closed as Fixed by syeghiay.
syeghiay added a new comment to an issue you are following: `` This has been completed. Closing. ``
To reply, visit the link below or just reply to this email https://pagure.io/releng/issue/7499
rel-eng@lists.fedoraproject.org
-
Dusty Mabe -
Kellin
-
Matthew Miller
-
Peter Robinson
-
Suzanne Yeghiayan