sgallagh opened a new pull-request against the project: `pungi-fedora` that you are following: `` Fix locale installation on Server DVD ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/878
sgallagh commented on the pull-request: `Fix locale installation on Server DVD` that you are following: `` @adamwill Could you have a look please? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/878
adamwill commented on the pull-request: `Fix locale installation on Server DVD` that you are following: `` Seems okay to me, yeah. The only thing I'd like to understand better is why we have this split between the variants definition file and this additional_packages in the config, but I feel like this ought to work at least. Maybe the variant definition can only list groups, not packages? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/878
sgallagh commented on the pull-request: `Fix locale installation on Server DVD` that you are following: `` That's how I'm reading https://pagure.io/pungi/blob/master/f/share/variants.dtd yeah. It looks like the only packages that can be specified are those needed for the buildinstall step. Everything else has to be in a group.
I suppose the other option would be to create a new `comps.xml` group containing all of the langpacks, but since comps doesn't support globs, that would likely be impossible to maintain in the long-term. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/878
mohanboddu merged a pull-request against the project: `pungi-fedora` that you are following.
Merged pull-request:
`` Fix locale installation on Server DVD ``
rel-eng@lists.fedoraproject.org