-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/32/#review40
-----------------------------------------------------------
blockerbugs/util/bug_sync.py
<
http://reviewboard-tflink.rhcloud.com/r/32/#comment63>
I'm nitpicking a bit here, but I don't see the reason for this change. it
makes the code harder to read and I fail to see the benefit.
It probably needs a commit about what last_sync_time = None means, though (full query
in bugzilla/bodhi without time restrictions)
Overall looks good to me, feel free to push the code after fixing the last issue - no need
for another round of review
- Tim Flink
On July 3, 2013, 2:50 p.m., Ilgiz Islamgulov wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/32/
-----------------------------------------------------------
(Updated July 3, 2013, 2:50 p.m.)
Review request for blockerbugs.
Repository: blockerbugs
Description
-------
Simple tests for rendering html templates.
Diffs
-----
testing/test_controllers.py PRE-CREATION
blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3
blockerbugs/templates/base_nav.html 021ddb3126b4c0f30a231d8d9b32df09c669280e
blockerbugs/models/release.py 2f74a69cec0b7769d4e6c21b7a4a84105c5d8a64
blockerbugs/controllers/main.py a8082121576015a86c31bc76ebc17e982062a08b
Diff:
http://reviewboard-tflink.rhcloud.com/r/32/diff/
Testing
-------
Thanks,
Ilgiz Islamgulov