-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/37/
-----------------------------------------------------------
Review request for blockerbugs.
Repository: blockerbugs
Description
-------
commit abf5fe2abbcfbce45d103864f5ba40fc89f233fa
Author: Martin Krizek <mkrizek(a)redhat.com>
Date: Tue Jul 16 13:57:28 2013 +0200
Fix sequences in alembic
Sequences need to be created separately. The patch also fixes a few
typos.
https://bitbucket.org/zzzeek/alembic/issue/73/more-pg-nextval-it-needs-the-…
Diffs
-----
alembic/versions/487cb8ccce92_dropping_flask_login.py e64dacb2e3b1a3d14bf38e1116df183ded9793d9
alembic/versions/1d12b74d12bd_add_userinfo_table.py 86dc390ed5e49b0a3ca058e163bc02b070d3d294
Diff: http://reviewboard-tflink.rhcloud.com/r/37/diff/
Testing
-------
Thanks,
Martin Krizek
#381: Bug and Update syncs shouldn't be halted by an isolated problem with one
update or bug
--------------------------------------+----------------------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: major | Milestone: Undetermined Future
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+----------------------------------
= problem =
The current bug and update sync algorithms are very fragile in that one
error will stop the entire sync algorithm, leaving stuff out of sync with
bodhi or bugzilla. This has caused problems in the past
= analysis =
This could be solved by better error handling in the sync process such
that an error is logged but doesn't bubble up to the main sync code and
halt the entire process.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/381>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
#384: Improve documentation
--------------------------------------+------------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: major | Milestone: Fedora 20
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+------------------------
= problem =
At the moment, our documentation is out of date and somewhat incomplete.
= analysis =
Update the docs and find an appropriate place for them to live.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/384>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
#387: Updates pending stable show as stable
--------------------------------------+---------------------
Reporter: kparal | Owner: tflink
Type: defect | Status: new
Priority: minor | Milestone:
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+---------------------
A package that is in updates-testing and is pending stable is shown as
[stable] in the app. That can cause some confusion (i.e. one of us can
close a related bug by assuming the package is already stable, and the
package push can be cancelled afterwards).
I think the app should display the repository the package is currently in,
not the repository the package in pending to. What do you think?
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/387>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
#386: Update URLs should comtain the update ID when possible
--------------------------------------+----------------------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: minor | Milestone: Undetermined Future
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+----------------------------------
= problem =
The update URLs fetched from bodhi are most reliable when they are based
off of the update ID which is generated when the update is pushed to
testing. However, the blocker tracking app generally grabs the URL before
this happens and thus, end up with the preliminary url based on update
contents.
= analysis =
The update sync process should look to replace any update URLs which are
not based on the update ID when the sync runs against bodhi.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/386>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
#392: ReSTful API
--------------------------------------+-------------------------
Reporter: islamgulov | Owner: islamgulov
Type: enhancement | Status: new
Priority: major | Milestone: Fedora 20
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+-------------------------
= problem =
At the moment, Blocker bug tracker app has not API.
= analysis =
API is defined as RESTful HTTP service.
API support JSON data serialization request and response formats.
`application/json` in the Content-Type header required in the request.
Time is specified as an ISO 8601 dateTime (2011-01-24T17:08Z).
List operations return all items at a time (no paging).
Endpoints:
1) Lists bugs associated with a milestone.
GET /api/v<api version>/miletstone/<rel_num>/<version>/bug?type=type&
To filter the list of bugs, you can specify the following optional URI
parameters:
- type=type& - Filters the list of bugs by type.
List bugs response fields:
- bzid: Bugzilla bug id
- url
- summary
- status
- component
- active
- type
Possible values for the bug type attribute include: 'proposed_blocker',
'proposed_fe', 'accepted_blocker', 'accepted_fe', 'rejected_blocker',
'rejected_fe'.
2) Lists updates associated with a milestone.
GET /api/v<api
version>/miletstone/<rel_num>/<version>/update?bugtype=bugtype&
Parameters:
- bugtype=bugtype& - Filters the list of update by type of bugs.
List updates response fields:
- title
- url
- karma
- stable_karma
- status
- pending
- bugs:
- bzid
- type
- release
- milestones:
- version
3) Lists spins associated with a milestone.
GET /api/v<api version>/miletstone/<rel_num>/<version>/spin/
List spins response fields:
- id
- name
- state
- url
- date_requested
- date_created
- spin_type
- updates:
- title
- status
- url
- succeeds:
- id
- milestone
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/392>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/38/
-----------------------------------------------------------
Review request for blockerbugs.
Repository: blockerbugs
Description
-------
commit e08c8ee1085bb0beb71b4a5c98c9d2e2497773cb
Author: Martin Krizek <mkrizek(a)redhat.com>
Date: Mon Jul 15 11:28:09 2013 +0200
Use fake login only in DEV environment
commit 8f175a28ae43b764e52435d174d73e2dc384bd6b
Author: Martin Krizek <mkrizek(a)redhat.com>
Date: Thu Jul 4 11:14:40 2013 +0200
Add developer login
This patch allows a fake login when DEV or TEST is set so we don't
access FAS server each time we log in.
TODO this will be merged with changes made in other review request dealing with fas-openid migrations.
Diffs
-----
blockerbugs/util/login.py PRE-CREATION
blockerbugs/templates/layout.html 8dc6deacd5e7a71757ed2564fb224b3cd92bfad5
blockerbugs/controllers/users.py 6f89a0b29143a9c09fcf25d97d875a01b9955fa4
blockerbugs/controllers/main.py a8082121576015a86c31bc76ebc17e982062a08b
blockerbugs/__init__.py 798fc6ecd562d1e13fbba26f804f74e6da670120
Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/
Testing
-------
Thanks,
Martin Krizek