[Fedora QA] #381: Bug and Update syncs shouldn't be halted by an isolated problem with one update or bug
by fedora-badges
#381: Bug and Update syncs shouldn't be halted by an isolated problem with one
update or bug
--------------------------------------+----------------------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: major | Milestone: Undetermined Future
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+----------------------------------
= problem =
The current bug and update sync algorithms are very fragile in that one
error will stop the entire sync algorithm, leaving stuff out of sync with
bodhi or bugzilla. This has caused problems in the past
= analysis =
This could be solved by better error handling in the sync process such
that an error is logged but doesn't bubble up to the main sync code and
halt the entire process.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/381>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
9 years, 8 months
[Fedora QA] #384: Improve documentation
by fedora-badges
#384: Improve documentation
--------------------------------------+------------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: major | Milestone: Fedora 20
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+------------------------
= problem =
At the moment, our documentation is out of date and somewhat incomplete.
= analysis =
Update the docs and find an appropriate place for them to live.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/384>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
9 years, 8 months
[Fedora QA] #387: Updates pending stable show as stable
by fedora-badges
#387: Updates pending stable show as stable
--------------------------------------+---------------------
Reporter: kparal | Owner: tflink
Type: defect | Status: new
Priority: minor | Milestone:
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+---------------------
A package that is in updates-testing and is pending stable is shown as
[stable] in the app. That can cause some confusion (i.e. one of us can
close a related bug by assuming the package is already stable, and the
package push can be cancelled afterwards).
I think the app should display the repository the package is currently in,
not the repository the package in pending to. What do you think?
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/387>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
9 years, 9 months
Review Request 45: Improve asset management
by Martin Krizek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/45/
-----------------------------------------------------------
Review request for blockerbugs.
Bugs: 357
https://fedorahosted.org/fedora-qa/ticket/357
Repository: blockerbugs
Description
-------
commit d86f88d7f9da899ffef44ad617a8a831327b7d80
Author: Martin Krizek <mkrizek(a)redhat.com>
Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management
Fixes: #357
I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
Diffs
-----
requirements.txt 09e0318bc189512f5d324bda8879ad74c4763f95
blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0
blockerbugs/__init__.py bd9973579e80fc859f3e8d22c35753fbd024c5f0
Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
Testing
-------
Loaded pages, seems like css and js work as expected after being minified.
Thanks,
Martin Krizek
9 years, 10 months
Review Request 42: Indicate bugs that are needinfo
by Martin Krizek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/42/
-----------------------------------------------------------
Review request for blockerbugs.
Bugs: 316
https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description
-------
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs
-----
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c
blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3
blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3
blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e
blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7
blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c
alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing
-------
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
9 years, 10 months
[Fedora QA] #386: Update URLs should comtain the update ID when possible
by fedora-badges
#386: Update URLs should comtain the update ID when possible
--------------------------------------+----------------------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: minor | Milestone: Undetermined Future
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+----------------------------------
= problem =
The update URLs fetched from bodhi are most reliable when they are based
off of the update ID which is generated when the update is pushed to
testing. However, the blocker tracking app generally grabs the URL before
this happens and thus, end up with the preliminary url based on update
contents.
= analysis =
The update sync process should look to replace any update URLs which are
not based on the update ID when the sync runs against bodhi.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/386>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
9 years, 12 months
Review Request 46: New admin interface and builds support
by Martin Krizek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/
-----------------------------------------------------------
Review request for blockerbugs.
Repository: blockerbugs
Description
-------
Implement new admin interface with flask-admin
Add build support
Diffs
-----
testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1
testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849
testing/test_api.py 15ddd7dd03c5d3675fab78c70f2687b838d94b08
setup.py 8a55d39674daf9bd240220ed8a147a691aa23a66
sass/admin_layout.scss PRE-CREATION
requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018
blockerbugs/util/koji_interface.py PRE-CREATION
blockerbugs/templates/spin_list.html c455ff4edec0991a453a94cd0e38d959e1757672
blockerbugs/templates/admin_layout.html PRE-CREATION
blockerbugs/templates/admin/modify_release.html a3bb0d95c49414ff977e82f828ffdd111e105cc6
blockerbugs/templates/admin/main.html 251b1df1647e307e89bcda365422f1cee59b9a35
blockerbugs/templates/admin/admin_nav.html 34a0c2a966c265ab66166b3170f5f6d507014149
blockerbugs/templates/admin/add_spin.html be44830da436e4e87700fe940a7c5197b32d1e82
blockerbugs/templates/admin/add_release.html 931001b23f52dd1b75fe0feb8d0311b76fcc907e
blockerbugs/static/js/admin.js PRE-CREATION
blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189
blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78
blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4
blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2
blockerbugs/models/build.py PRE-CREATION
blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2
blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd
blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50
blockerbugs/controllers/api/utils.py 38144dd48f3190f709a9bafa3a5a425dfdfffbdf
blockerbugs/controllers/api/api.py 30de9189473bb8bbeb63b7578e5e21de0a51d2d7
blockerbugs/controllers/admin/spin.py PRE-CREATION
blockerbugs/controllers/admin/build.py PRE-CREATION
blockerbugs/controllers/admin/auth.py PRE-CREATION
blockerbugs/controllers/admin/__init__.py PRE-CREATION
blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a
blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186
blockerbugs/__init__.py 1bac593a334a848308fdb362deee496a046293e8
blockerbugs.spec 083c7c29789e172d48e455413478f376ef3eb099
alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION
alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
Testing
-------
I've tested on my develop instance.
Thanks,
Ilgiz Islamgulov
9 years, 12 months
[Fedora QA] #390: modifying milestone through admin web interface generates http 500 errors
by fedora-badges
#390: modifying milestone through admin web interface generates http 500 errors
--------------------------------------+------------------------
Reporter: tflink | Owner: tflink
Type: defect | Status: new
Priority: critical | Milestone: Fedora 20
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+------------------------
= bug description =
When changing a milestone through the web admin interface, saving changes
generates a http 500 error with the following traceback:
{{{
Traceback (most recent call last):
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/flask/app.py", line 1701, in __call__
return self.wsgi_app(environ, start_response)
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/flask/app.py", line 1689, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/flask/app.py", line 1687, in wsgi_app
response = self.full_dispatch_request()
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/flask/app.py", line 1360, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/flask/app.py", line 1358, in full_dispatch_request
rv = self.dispatch_request()
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/flask/app.py", line 1344, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/home/tflink/code/blockerbugs/blockerbugs/controllers/users.py",
line 95, in decorated_function
return f(*args, **kwargs)
File "/home/tflink/code/blockerbugs/blockerbugs/controllers/admin.py",
line 148, in modify_milestone
milestone.succeeds = selected_succeeds
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/sqlalchemy/orm/attributes.py", line 155, in __set__
instance_dict(instance), value, None)
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/sqlalchemy/orm/dynamic.py", line 117, in set
self._set_iterable(state, dict_, value)
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-
packages/sqlalchemy/orm/dynamic.py", line 122, in _set_iterable
new_values = list(iterable)
TypeError: 'Milestone' object is not iterable
}}}
= fix recommendation =
Saving the milestone shouldn't tb and the save operation should complete
successfully
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/390>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
10 years