This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/32/ |
blockerbugs/util/bug_sync.py (Diff revision 3) | |||
---|---|---|---|
def update_active(self, full_sync=False): |
|||
149 | last_sync_time = milestone.last_bug_sync |
149 | last_sync_time = None if full_sync else milestone.last_bug_sync |
I'm nitpicking a bit here, but I don't see the reason for this change. it makes the code harder to read and I fail to see the benefit. It probably needs a commit about what last_sync_time = None means, though (full query in bugzilla/bodhi without time restrictions)
Overall looks good to me, feel free to push the code after fixing the last issue - no need for another round of review
- Tim Flink
On July 3rd, 2013, 2:50 p.m. UTC, Ilgiz Islamgulov wrote:
Review request for blockerbugs.
By Ilgiz Islamgulov.
Updated July 3, 2013, 2:50 p.m.
Repository:
blockerbugs
Description
Diffs
|