On Thu, Jul 11, 2013 at 01:37:36PM +0200, Tomas Mraz wrote:
On Fri, 2013-06-21 at 17:26 +0200, Tomas Mraz wrote:
> pam_pwhistory needs to run a helper to save hashes from /etc/shadow
> to /etc/security/opasswd as these files have shadow_t context.
>
> Although current policy allows for passwd command to work with it it
> would not be possible to change expired passwords with login and other
> services.
>
> The attached patch implements the helper which is called when SELinux is
> enabled.
>
> Please review.
Ping? Anybody wants to review this patch?
First of all, my "git am" complained loudly about this patch:
modules/pam_pwhistory/pam_pwhistory.c:180: trailing whitespace.
+ }
modules/pam_pwhistory/pam_pwhistory.c:252: trailing whitespace.
+
modules/pam_pwhistory/pam_pwhistory.c:277: trailing whitespace.
+ }
modules/pam_pwhistory/pam_pwhistory.c:342: trailing whitespace.
+ if (retval == PAM_PWHISTORY_RUN_HELPER)
modules/pam_pwhistory/pwhistory_helper.c:1: trailing whitespace.
+/*
modules/pam_pwhistory/pwhistory_helper.c:73: trailing whitespace.
+
modules/pam_pwhistory/pwhistory_helper.c:131: trailing whitespace.
+ if (offset > 0 && npass > 0)
modules/pam_pwhistory/pwhistory_helper.c:209: new blank line at EOF.
Please make your .git/hooks/pre-commit reject these whitespace errors,
so they won't end up in the public repository.
Second, it looks like this patch contains large cut-n-paste hunks from
pam_unix. Is it possible to reuse the code without so much duplication?
--
ldv