On Thu, 2013-07-11 at 15:47 +0400, Dmitry V. Levin wrote:
On Thu, Jul 11, 2013 at 01:37:36PM +0200, Tomas Mraz wrote:
> On Fri, 2013-06-21 at 17:26 +0200, Tomas Mraz wrote:
> > pam_pwhistory needs to run a helper to save hashes from /etc/shadow
> > to /etc/security/opasswd as these files have shadow_t context.
> >
> > Although current policy allows for passwd command to work with it it
> > would not be possible to change expired passwords with login and other
> > services.
> >
> > The attached patch implements the helper which is called when SELinux is
> > enabled.
> >
> > Please review.
>
> Ping? Anybody wants to review this patch?
First of all, my "git am" complained loudly about this patch:
Please make your .git/hooks/pre-commit reject these whitespace
errors,
so they won't end up in the public repository.
I have the hook already enabled I just did not try to commit. Sorry for
that.
Second, it looks like this patch contains large cut-n-paste hunks
from
pam_unix. Is it possible to reuse the code without so much duplication?
I think I could factor out the functions that run the helper into the
libpam modutil function(s).
Doing it for the helper itself does not make much sense to me.
--
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb