https://bugzilla.redhat.com/show_bug.cgi?id=1481630
--- Comment #50 from Hans de Goede <hdegoede(a)redhat.com> ---
(In reply to Sergio Monteiro Basto from comment #33)
kmk need this [1] all least in my case ...
[1]
+ VBOX_PATH_APP_PRIVATE=%{_libdir}/virtualbox \
+ VBOX_PATH_APP_DOCS=%{_docdir}/VirtualBox \
That is not needed when building just the additions, the additions do not
install any files into these paths.
(In reply to Nicolas Chauvet (kwizart) from comment #41)
(In reply to Hans de Goede from comment #38)
Quick review with few minors things:
* Keep from using requires on kernel from userspace. Most of the time this
is invalid (you could be within a chroot , container or systemd-nspawn,
etc). Also you need to select the appropriate variant (on x86_64
kernel-debug exists or even kernel-rt).
# FIXME once kernel modules have landed
#Requires: kernel >= 4.FIXME
Fixed in the next version.
* Please use pkgconf --libs libpng and etc not to hardcode one
particular
library path. (say if there is a need to use one particular scl at some
point).
Fixed in the next version.
* Is there a way "not to hardcode the vendor", such as:
VBOX_BUILD_PUBLISHER=_%{?vendor}%{?!vendor:Unknown}
No that is not going to work, that would set the vendor to "_Fedora Project"
and it cannot contain spaces and I think that is too long too. vbox is very
picky about the version string into which this gets embedded. So it is best to
just hardcode this.
* The replacement of the RPM Fusion package should works for the
"userspace"
but not much for the kmod-VirtualBox. Best is probably to keep a (virtual)
Provides: VirtualBox-kmod-common = 5.2.2 (the last version of the rpmfusion
counterpart before it is disabled). So that kmod-Virtualbox is kept while it
will not try to seek the main VirtualBox(host) capability.
Then, it will only be a matter for the kernel
Obsoletes/Provides for the akmod isn't an option because it will affect host
kmod-VirtualBox and VirtualBox users.
Ok, I ve added a:
Provides: VirtualBox-kmod-common
To the .spec for the next version.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #44)
Package name should be virtualbox-guest-additions.
Fixed in the next version.
(In reply to Sergio Monteiro Basto from comment #49)
why keep VirtualBox-5.0.18-xserver_guest.patch [1] ?
Even with VBOX_USE_SYSTEM_GL_HEADERS=1 there still is one small issue breaking
compilation, in my pkg this is a modified version of your original patch
keeping only the small chunk still necessary.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component