https://bugzilla.redhat.com/show_bug.cgi?id=1481630
--- Comment #62 from Hans de Goede <hdegoede(a)redhat.com> ---
(In reply to Sergio Monteiro Basto from comment #60)
(In reply to Hans de Goede from comment #51)
> - Latest rpmfusion Release is 2, set our Release field to 3
Maybe could be better bump Epoch, for example VirtualBox had a rebuild today
...
No Epoch's are evil. We can simply bump the release a bit extra if needed and
rpmfusion should stop building the guest-additions sub-package for F28/rawhide
soon now. I plan to import and build the Fedora guest-additions package for
rawhide as soon as rawhide gets a 4.16-rc0 or rc1 with the vboxguest driver
enabled.
(In reply to Sergio Monteiro Basto from comment #61)
(In reply to Hans de Goede from comment #51)
> - Use pkgconfig to get include/libs instead of hardcoding (rhbz#1534595)
we can't use pkgconf, for example:
pkgconf --cflags libxml-2.0
-I/usr/include/libxml2
when we have to use [1] and result with pkgconf is [2] , which doesn't work .
[1]
SDK_VBOX_LIBXML2_INCS=/usr/include/libxml2
[2]
SDK_VBOX_LIBXML2_INCS=-I/usr/include/libxml2
Right, so this still worked because the additions don't care about any of the
includes I was setting this way, so for the next release I'm simply setting
them all to "".
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component