Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=907309
Petr Šabata <psabata(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #1 from Petr Šabata <psabata(a)redhat.com> ---
No issues, approving.
Just some tips, as usually :)
Use 'perl' instead of the '%{__perl}' macro.
Use DESTDIR instead of PERL_INSTALL_ROOT.
You have perl(vars) among your BRs. If you want to list pragmas, you should
add perl(strict) too, for consistence.
I'm not a native speaker but the language used in Summary and %description
looks a bit weird... perhaps you could make it better :)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=oPqLC60Vb8&a=cc_unsubscribe