Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=907309
Mathieu Bridon <bochecha(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-cvs?
--- Comment #2 from Mathieu Bridon <bochecha(a)fedoraproject.org> ---
(In reply to comment #1)
No issues, approving.
Just some tips, as usually :)
Use 'perl' instead of the '%{__perl}' macro.
Use DESTDIR instead of PERL_INSTALL_ROOT.
Gah! I'm getting tired of these two, so here come the bug reports:
https://bugzilla.redhat.com/show_bug.cgi?id=907704
https://bugzilla.redhat.com/show_bug.cgi?id=907703
Anyway, fixed.
You have perl(vars) among your BRs. If you want to list pragmas, you
should
add perl(strict) too, for consistence.
Heh, I guess I went too far when trying to not forget any build requirement on
core modules this time. :)
So I dropped the BR on perl(vars).
I'm not a native speaker but the language used in Summary and
%description
looks a bit weird... perhaps you could make it better :)
Changed it a bit, it should now read better.
-----
Once more, thanks for the review Petr!
For the record, here is the new package with the above items fixed.
Spec URL:
http://bochecha.fedorapeople.org/packages/perl-Text-ExtractWords.spec
SRPM URL:
http://bochecha.fedorapeople.org/packages/perl-Text-ExtractWords-0.08-2.f...
New Package SCM Request
=======================
Package Name: perl-Text-ExtractWords
Short Description: Perl extension to extract words from strings
Owners: bochecha
Branches: devel
InitialCC: perl-sig
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=aehF3M3a1H&a=cc_unsubscribe