https://bugzilla.redhat.com/show_bug.cgi?id=1982619
Otto Urpelainen <oturpe(a)iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oturpe(a)iki.fi
Assignee|nobody(a)fedoraproject.org |oturpe(a)iki.fi
Flags| |fedora-review?
| |needinfo?(ce(a)lcts.de)
--- Comment #1 from Otto Urpelainen <oturpe(a)iki.fi> ---
Reviewed.
1.
Summary: Thin assertion library for input validation in
business models
In composer.json it is:
"A PHP Framework that allows you to encode and decode arbitrary ASN.1
structures using the ITU-T X.690 Encoding Rules."
"
2.
Autoloader: %{_datadir}/php/%{ns_dir}/autoload.php
You may want to use the less specfile tag looking formatting here.
3.
: Create a PSR-0 tree
mkdir -p %{buildroot}%{_datadir}/php/%{ns_dir}
cp -pr lib/* %{buildroot}%{_datadir}/php/%{ns_dir}
In another review it was suggested
that %{ns_dir} should have two components: vendor and project [1].
Should the same logic apply here?
That would create a path fgrosse/FG, with FG being the project name.
That sounds strange, but perhaps that is just because
upstream chose a strange namespace name for this project?
[1]:
https://bugzilla.redhat.com/show_bug.cgi?id=1982616#c2
4.
%if 0%{?with_tests}
: Run tests
: No tests implemented
%endif
Upstream has them. I suppose makesrc.sh needs to be introduced.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component