https://bugzilla.redhat.com/show_bug.cgi?id=1982619
Christopher Engelhard <ce(a)lcts.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(ce(a)lcts.de) |needinfo?(oturpe(a)iki.fi)
--- Comment #4 from Christopher Engelhard <ce(a)lcts.de> ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/lcts/nextcloud/fedora-raw...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/lcts/nextcloud/fedora-raw...
Sorry for the delay, $DAYJOB intervened.
(In reply to Otto Urpelainen from comment #1)
1.
> Summary: Thin assertion library for input validation in business models
In composer.json it is:
"A PHP Framework that allows you to encode and decode arbitrary ASN.1
structures using the ITU-T X.690 Encoding Rules."
"
Fixed.
2.
> Autoloader: %{_datadir}/php/%{ns_dir}/autoload.php
You may want to use the less specfile tag looking formatting here.
Changed it to the same format as in php-league-uri-interfaces
3.
> : Create a PSR-0 tree
> mkdir -p %{buildroot}%{_datadir}/php/%{ns_dir}
> cp -pr lib/* %{buildroot}%{_datadir}/php/%{ns_dir}
In another review it was suggested
that %{ns_dir} should have two components: vendor and project [1].
Should the same logic apply here?
That would create a path fgrosse/FG, with FG being the project name.
That sounds strange, but perhaps that is just because
upstream chose a strange namespace name for this project?
[1]:
https://bugzilla.redhat.com/show_bug.cgi?id=1982616#c2
As Remi pointed out, this library is a bit of a mess. It's also the only
library the vendor has, so I think it's unlikely there will be any conflict
anytime soon. I left it at php/FG/.. for now, but I'll see if upstream is
interested in bringing a bit more order into this.
4.
> %if 0%{?with_tests}
> : Run tests
> : No tests implemented
> %endif
Upstream has them. I suppose makesrc.sh needs to be introduced.
Did that. I added a small patch to make the tests work with PHPUnit 8 since 7
is EOL. They can also be made compatible with PHPUnit 9, but that patch is
quite extensive. If you're OK with that I'd prefer to take that upstream since
PHPUnit 8 is still fully supported.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component