https://bugzilla.redhat.com/show_bug.cgi?id=1797363
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
|requires_doc_text? |
--- Comment #6 from Petr Pisar <ppisar(a)redhat.com> ---
The package was rebased. I will review it again.
Url and Source0 addresses are usable. Ok.
Source0 archive (SHA-256:
781b3d3b7e7b249702f1580b95051762723d2c4ef3941ee8b56661b64d87ee5a) is original.
Ok.
Summary verified from lib/Text/Layout.pm. Ok.
Description verified from README. Ok.
License verified from lib/Text/Layout.pm and README. Ok.
No XS code, noarch BuildArch is Ok.
PDF::Builder is optional for tests. Ok.
All tests pass. Ok.
$ rpmlint perl-Text-Layout.spec
../SRPMS/perl-Text-Layout-0.018.1-3.fc33.src.rpm
../RPMS/noarch/perl-Text-Layout-0.018.1-3.fc33.noarch.rpm
sh: /usr/bin/python2: No such file or directory
perl-Text-Layout.src: W: spelling-error Summary(en_US) Pango -> Tango, Mango,
Pan go
perl-Text-Layout.src: W: spelling-error %description -l en_US Backends -> Back
ends, Back-ends, Backhands
perl-Text-Layout.src: W: spelling-error %description -l en_US FontConfig ->
Configuration
perl-Text-Layout.noarch: W: spelling-error Summary(en_US) Pango -> Tango,
Mango, Pan go
perl-Text-Layout.noarch: W: spelling-error %description -l en_US Backends ->
Back ends, Back-ends, Backhands
perl-Text-Layout.noarch: W: spelling-error %description -l en_US FontConfig ->
Configuration
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Text-Layout-0.018.1-3.fc33.noarch.rpm
drwxr-xr-x 2 root root 0 Feb 27 16:58
/usr/share/doc/perl-Text-Layout
-rw-r--r-- 1 root root 973 Feb 27 14:45
/usr/share/doc/perl-Text-Layout/Changes
-rw-r--r-- 1 root root 2002 Jan 26 18:53
/usr/share/doc/perl-Text-Layout/README
-rw-r--r-- 1 root root 6606 Feb 27 16:58
/usr/share/man/man3/Text::Layout.3pm.gz
-rw-r--r-- 1 root root 2957 Feb 27 16:58
/usr/share/man/man3/Text::Layout::FontConfig.3pm.gz
-rw-r--r-- 1 root root 1900 Feb 27 16:58
/usr/share/man/man3/Text::Layout::FontDescriptor.3pm.gz
drwxr-xr-x 2 root root 0 Feb 27 16:58
/usr/share/perl5/vendor_perl/Text
drwxr-xr-x 2 root root 0 Feb 27 16:58
/usr/share/perl5/vendor_perl/Text/Layout
-rw-r--r-- 1 root root 26585 Feb 27 14:45
/usr/share/perl5/vendor_perl/Text/Layout.pm
-rw-r--r-- 1 root root 154 Feb 27 14:45
/usr/share/perl5/vendor_perl/Text/Layout/Cairo.pm
-rw-r--r-- 1 root root 13482 Feb 27 14:45
/usr/share/perl5/vendor_perl/Text/Layout/FontConfig.pm
-rw-r--r-- 1 root root 3380 Feb 27 14:45
/usr/share/perl5/vendor_perl/Text/Layout/FontDescriptor.pm
-rw-r--r-- 1 root root 967 Feb 27 14:45
/usr/share/perl5/vendor_perl/Text/Layout/Markdown.pm
-rw-r--r-- 1 root root 5484 Feb 27 14:45
/usr/share/perl5/vendor_perl/Text/Layout/PDFAPI2.pm
-rw-r--r-- 1 root root 154 Feb 27 14:45
/usr/share/perl5/vendor_perl/Text/Layout/Pango.pm
A file layout and the permissions are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-Text-Layout-0.018.1-3.fc33.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.30.1)
1 perl(:VERSION) >= 5.10.1
1 perl(Carp)
1 perl(constant)
1 perl(File::Basename)
1 perl(overload)
1 perl(strict)
1 perl(utf8)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --provides -p
../RPMS/noarch/perl-Text-Layout-0.018.1-3.fc33.noarch.rpm | sort -f | uniq -c
1 perl(Text::Layout) = 0.018.1
1 perl(Text::Layout::FontConfig) = 0.018.1
1 perl(Text::Layout::FontDescriptor) = 0.018.1
1 perl-Text-Layout = 0.018.1-3.fc33
Binary provides are Ok.
$ resolvedeps f33-build
../RPMS/noarch/perl-Text-Layout-0.018.1-3.fc33.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in F33
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=41969664). Ok.
The package is in line with Fedora and Perl packaging guide lines.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component