https://bugzilla.redhat.com/show_bug.cgi?id=1797363
--- Comment #4 from Petr Pisar <ppisar(a)redhat.com> ---
The package was rebased. I will review it again.
Url and Source0 addresses are usable. Ok.
Source0 archive (SHA-256:
65b0eada14bbfcf687fabc31d162bdf154c803ba8a10d83d118561d4f10c181d) is original.
Ok.
License verified from lib/Text/Layout.pm and README. Ok.
Summary verified from lib/Text/Layout.pm. Ok.
Description verified from README. Ok.
No XS code, noarch BuildArch is Ok.
FIX: The minimal perl(ExtUtils::MakeMaker) version should be 6.76. Not 6.46. I
made a mistake in my previous comment.
PDF::Builder is optional for tests. Ok.
TODO: Either correct perl(HarfBuzz::Shaper) minimal version to 0.019
(t/00-load.t:14) or remove the version, because the tests continue even without
that.
All tests pass. Ok.
$ rpmlint perl-Text-Layout.spec ../SRPMS/perl-Text-Layout-0.018-2.fc33.src.rpm
../RPMS/noarch/perl-Text-Layout-0.018-2.fc33.noarch.rpm
sh: /usr/bin/python2: No such file or directory
perl-Text-Layout.src: W: spelling-error Summary(en_US) Pango -> Tango, Mango,
Pan go
perl-Text-Layout.src: W: spelling-error %description -l en_US Backends -> Back
ends, Back-ends, Backhands
perl-Text-Layout.src: W: spelling-error %description -l en_US FontConfig ->
Configuration
perl-Text-Layout.noarch: W: spelling-error Summary(en_US) Pango -> Tango,
Mango, Pan go
perl-Text-Layout.noarch: W: spelling-error %description -l en_US Backends ->
Back ends, Back-ends, Backhands
perl-Text-Layout.noarch: W: spelling-error %description -l en_US FontConfig ->
Configuration
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Text-Layout-0.018-2.fc33.noarch.rpm
t@fedora-33 SPECS]$ rpm -q -lv -p
../RPMS/noarch/perl-Text-Layout-0.018-2.fc33.noarch.rpm
drwxr-xr-x 2 root root 0 Feb 27 12:52
/usr/share/doc/perl-Text-Layout
-rw-r--r-- 1 root root 971 Feb 6 16:45
/usr/share/doc/perl-Text-Layout/Changes
-rw-r--r-- 1 root root 2002 Jan 26 18:53
/usr/share/doc/perl-Text-Layout/README
-rw-r--r-- 1 root root 6606 Feb 27 12:52
/usr/share/man/man3/Text::Layout.3pm.gz
-rw-r--r-- 1 root root 2957 Feb 27 12:52
/usr/share/man/man3/Text::Layout::FontConfig.3pm.gz
-rw-r--r-- 1 root root 1900 Feb 27 12:52
/usr/share/man/man3/Text::Layout::FontDescriptor.3pm.gz
drwxr-xr-x 2 root root 0 Feb 27 12:52
/usr/share/perl5/vendor_perl/Text
drwxr-xr-x 2 root root 0 Feb 27 12:52
/usr/share/perl5/vendor_perl/Text/Layout
-rw-r--r-- 1 root root 26583 Feb 6 16:45
/usr/share/perl5/vendor_perl/Text/Layout.pm
-rw-r--r-- 1 root root 154 Feb 6 16:45
/usr/share/perl5/vendor_perl/Text/Layout/Cairo.pm
-rw-r--r-- 1 root root 13480 Feb 6 16:45
/usr/share/perl5/vendor_perl/Text/Layout/FontConfig.pm
-rw-r--r-- 1 root root 3378 Feb 6 16:45
/usr/share/perl5/vendor_perl/Text/Layout/FontDescriptor.pm
-rw-r--r-- 1 root root 967 Feb 6 16:45
/usr/share/perl5/vendor_perl/Text/Layout/Markdown.pm
-rw-r--r-- 1 root root 5484 Feb 6 16:45
/usr/share/perl5/vendor_perl/Text/Layout/PDFAPI2.pm
-rw-r--r-- 1 root root 154 Feb 6 16:45
/usr/share/perl5/vendor_perl/Text/Layout/Pango.pm
A file layout and the permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Text-Layout-0.018-2.fc33.noarch.rpm
| sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.30.1)
1 perl(:VERSION) >= 5.10.1
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
FIX: Run-require:
perl(Carp) lib/Text/Layout.pm:9
perl(constant) lib/Text/Layout.pm:115
perl(File::Basename) lib/Text/Layout/FontConfig.pm:437
perl(overload) lib/Text/Layout/FontDescriptor.pm:197
perl(strict) lib/Text/Layout.pm:3
perl(utf8) lib/Text/Layout.pm:5
perl(warnings) lib/Text/Layout.pm:4
Alternatively stop disabling the depenency generators (AutoReqProv) and they
will appear automatically.
$ rpm -q --provides -p ../RPMS/noarch/perl-Text-Layout-0.018-2.fc33.noarch.rpm
| sort -f | uniq -c
1 perl(Font::Config) = 0.018
1 perl(Font::Descriptor) = 0.018
1 perl(Text::Layout) = 0.018
1 perl-Text-Layout = 0.018-2.fc33
FIX: Stop providing 'perl(Font::Config)' and 'perl(Font::Descriptor)'.
They are
not delivered by this package.
TODO: Provide all the other Text::Layout::* modules. They are there, they have
documentation, they are indexed by CPAN.
Maybe should keep AutoReqProv enabled and filter only those that you don't need
<
https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAnd...;.
$ resolvedeps f33-build ../RPMS/noarch/perl-Text-Layout-0.018-2.fc33.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in F33
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=41966469). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a
new
spec file.
Resolution: Package NOT approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component