https://bugzilla.redhat.com/show_bug.cgi?id=2007791
--- Comment #12 from Mikolaj Izdebski <mizdebsk(a)redhat.com> ---
Some initial findings:
- URL in the spec file is broken, it points to "Page not found"
- license should include BSD, as some of the source files are under BSD (v8dtoa
and treetable); licensing breakdown should be added as a comment
- missing Requires on javapackages-tools in rhino-engine package break the
launcher script
- test failures are worrying and should be fixed (this is highly recommended,
but not mandatory; failing tests are not review blockers; I can still approve
the package even if you insist on ignoring test failures)
Regarding test failures, I've attempted to fix them. Different test failures
and errors can be fixed by:
- changing working directory where tests are ran (workingDirectory setting of
maven-surefire-plugin); tests expect resources in certain locations relative to
CWD
- running each test in a separate fork (forkCount=1, reuseForks=false settings
of surefire); many tests do not clean up contexts properly, this makes the
tests much more resilient at the expense of performance. See comment in
build.gradle line 84
- changing version of junit test dependency from SYSTEM to 4.13; surefire needs
this to detect junit version in use; if you set version to SYSTEM surefire
assumes junit 3
- setting various system properties (see lines 75-81 of build.gradle)
Benchmark tests will probably need to be disabled, or their expected times
adjusted, otherwise they will fail in Koji on ARM.
Can you fix the above issues and failing tests?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2007791