[Bug 175047] Review Request: NetworkManager-openvpn
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: NetworkManager-openvpn
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175047
------- Additional Comments From j.w.r.degoede(a)hhs.nl 2006-08-11 01:02 EST -------
(In reply to comment #38)
> A new package is available at
>
http://www.niemueller.de/projects/extrpms/packages/fedora-extras-5/Networ...
> (the spec is available at
>
http://www.niemueller.de/projects/extrpms/packages/fedora-extras-5/Networ...
> now). Cleaned up and incorporated most suggestions.
>
> Upstream: It's from the 0.6 branch (0.6.4 tag) from CVS. The more recent
> versions are incompatible because the VPN DBUS API has changed.
> There are no tarballs, source is only available in CVS, thus no URL tag for now.
>
> Four warnings remain:
> W: NetworkManager-openvpn no-url-tag
> explained above
>
Okay, please add a comment above source0 with the bash commands which can be
used to recreate the tarbal (I know the tarbal might not be the same because
CVS has chanced, but thats ok).
> W: NetworkManager-openvpn conffile-without-noreplace-flag
> /etc/NetworkManager/VPN/nm-openvpn-service.name
> W: NetworkManager-openvpn conffile-without-noreplace-flag
> /etc/dbus-1/system.d/nm-openvpn-service.conf
>
> These are directly relevant to a functioning service and should not be modified,
> thus I did not add noreplace (for if the files have to change during an
> upgrade). If it is policy to add noreplace anyway I can easily do this but from
> my understanding this is just error prone.
>
OK
> W: NetworkManager-openvpn devel-file-in-non-devel-package
> /usr/lib/libnm-openvpn-properties.so
>
> This is needed, it contains the GUI for configuring the VPN and is called from
> inside NM (to be more precise: nm-vpn-properties).
>
OK
> The find_lang has been removed for now. It should be used for i18n support but
> only threw errors so I commented it out.
>
OK
TODO:
-Add an URL tag (see previous comments by others)
-Add comments to Source0 to explain how the tarbal was created
-Remove this as its probably no longer needed:
"rm -f %{buildroot}%{_libdir}/lib*.a", if it is still needed then the
--disable-static %configure argument isn't working and should be removed
-Remove these 2 lines:
Requires(post): %{_bindir}/gtk-update-icon-cache
Requires(postun): %{_bindir}/gtk-update-icon-cache
These are not needed / unwanted, the scrip checks for existence of this
file before using it and if its not there there is no reason to call it.
Once these are done (assuming you agree with the proposed changes) I'll approve
this and sponsor you. Feel free to create an account in the account system /
request FE membership if you alreadty have one, then I can approve and sponsor
in one go.
"
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 9 months
[Bug 181445] Review Request: php-shout
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-shout
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181445
------- Additional Comments From tibbs(a)math.uh.edu 2006-08-10 17:53 EST -------
I know this has sat around for too long, but the end is in sight. The packaging
committee accepted the PHP guideline draft, although honestly it didn't say much
about extensions like this one.
In any case, I'm ready to move forward with this review.
The first problem is that it doesn't build; I had to add a BR: on pkgconfig.
Previously you indicated that this wasn't required, but it certainly is a
problem. Perhaps the new minimal buildroots have changed things since you were
able to build without the BR.
rpmlint finds this in SRPM:
W: php-shout macro-in-%changelog buildroot
You just need to double a percent sign somewhere.
and in the built RPM:
E: php-shout script-without-shellbang /usr/share/doc/php-shout-0.3.1/TODO
E: php-shout script-without-shellbang /usr/share/doc/php-shout-0.3.1/README
These are executable for some reason, and shouldn't be.
E: php-shout-debuginfo script-without-shellbang
/usr/src/debug/phpShout-0.3.1/php_shout.h
E: php-shout-debuginfo script-without-shellbang
/usr/src/debug/phpShout-0.3.1/php_shout.c
These source files are executable, and should be chmodded in %prep.
The final set of macros which were chosen:
%global php_apiver %((echo 0; php -i 2>/dev/null | sed -n 's/^PHP API => //p')
| tail -1)
%global php_extdir %(php-config --extension-dir 2>/dev/null || echo "undefined")
Care to fix things up to use those?
Finally, I can't fetch the upstream source from the given URL. The only thing
that seems to be available is 0.3a.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 9 months
[Bug 174021] Review Request: aplus-fsf - Advanced APL Interpreter
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: aplus-fsf - Advanced APL Interpreter
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174021
gemi(a)bluewin.ch changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |NEW
Keywords| |Reopened
Resolution|NEXTRELEASE |
------- Additional Comments From gemi(a)bluewin.ch 2006-08-10 14:50 EST -------
(In reply to comment #25)
> The release has the following problems:
> - aplus.el contains /usr/local/bin/a+ instead of /usr/bin/a+
This is not fixed.
> - on startup of a+
> /usr/lib/idap.+: No such file or directory
> somethere a path /usr/lib must be changed to /usr/lib/a+
Fixed.
As to fonts:
file /usr/share/fonts/apl is not owned by any package
the x11 fonts should remain in /usr/share/X11/fonts, only the
truetype fonts need to go to /usr/share/fonts.
I propose the following:
fonts-truetype-apl (is it really necessary to include this in the X11 font
path?):
/usr/share/fonts/apl
/usr/share/fonts/apl/KAPL.TTF
fonts-x11-apl:
/usr/share/X11/fonts/apl
/usr/share/X11/fonts/apl/fonts.alias
/usr/share/X11/fonts/apl/fonts.dir
/usr/share/X11/fonts/apl/Kaplcour-14.pcf.gz
/usr/share/X11/fonts/apl/Kaplgallant-19.pcf.gz
/usr/share/X11/fonts/apl/Kaplscreen-11.pcf.gz
/usr/share/X11/fonts/apl/Kaplscreen-Bold-14.pcf.gz
Please make sure that the correct files and also the directories
are included in the files list.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 9 months