[Bug 187610] Review Request: crm114 - CRM114 Bayesian Spam Detector
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: crm114 - CRM114 Bayesian Spam Detector
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187610
------- Additional Comments From paul(a)all-the-johnsons.co.uk 2006-08-14 17:26 EST -------
Release: %{rel}.%{cvsver} - you need the %{?dist} tag adding
%build
%{__make} %{?_smp_mflags} INSTALL_DIR=$RPM_BUILD_ROOT%{_bindir}
CFLAGS="$RPM_OPT_FLAGS"
does the install dir need to be here (and the CFLAGS)?
install -d $RPM_BUILD_ROOT{%{_bindir},%{_datadir}/%{name}}
the make install should create these directories for you. If they don't, mkdir
-p is the way to go.
%{__make} BINDIR=${RPM_BUILD_ROOT}%{_bindir} install
Isn't make DEST_DIR=%{buildroot} install more usual?
%{_datadir}/%{name}/*.crm
This just needs to be %{_datadir}/%{name}/
The binary files should already be 755, so the %defattr before them shouldn't be
required.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 9 months
[Bug 182320] Review Request: gnome-build
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-build
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182320
paul(a)all-the-johnsons.co.uk changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution| |NEXTRELEASE
------- Additional Comments From paul(a)all-the-johnsons.co.uk 2006-08-14 17:14 EST -------
Thanks for the review. Much appreciated.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 9 months
[Bug 182320] Review Request: gnome-build
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-build
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182320
jpmahowald(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From jpmahowald(a)gmail.com 2006-08-14 17:03 EST -------
rpmlint just says W: gnome-build-devel no-documentation
Dependencies OK.
APPROVED as per comment 23.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 9 months
[Bug 176253] Review Request: clement-2.1
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: clement-2.1
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176253
------- Additional Comments From bugs.michael(a)gmx.net 2006-08-14 12:18 EST -------
There is no policy which says that all rpmlint errors/warnings must be
fixed.
Look at it from a different perspective to understand. There is nothing
about this in the Package Review Guidelines. Nothing at all about creating
user/group accounts. Not even the guideline about "setuid root" from
fedora.us QACheckList is included. When we agreed on the initial rather
long list of MUST/SHOULD items in a FESCO meeting, we didn't cover
useradd/groupadd/userdel/groupdel or fedora-useradd and friends.
| http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
|
| - SHOULD: If scriptlets are used, those scriptlets must be sane.
| This is vague, and left up to the reviewers judgement to determine
| sanity.
If anything had changed over time, it should have been announced
clearly.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 9 months
[Bug 176253] Review Request: clement-2.1
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: clement-2.1
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176253
------- Additional Comments From j.w.r.degoede(a)hhs.nl 2006-08-14 10:48 EST -------
A bit late due to a bugzilla collision, but I fully agree with Michael:
(In reply to comment #23)
> So I added clement as group & user as suggested.
>
> got this from rpmlint (many lines of this kind)
>
> E: clement non-standard-gid /var/spool/clement-2.1/mqueue clement
> A file in this package is owned by a non standard group.
> Standard groups are:
> root, bin, daemon, sys, adm, tty, disk, lp, mem, kmem, wheel, mail,
> news, uucp, man, games, gopher, dip, ftp, lock, nobody, users
>
>
> Does not look like as a 'Warning' to me, how to make it as a Warning?
>
Erm, so its an error (my mistake), still it can be ignored, rpmlint us an
automated validation tool and sometimes it can be just plain wrong. Trust me
(and Michael) on this between the 2 of us there is a ton of packaging experience.
>
> Also got this warning
> W: clement dangerous-command-in-%preun userdel
> because I would like to delete created user when removing all the application,
> there is a kind of ambiguity here as some file could be left if the application
> was in production previously.
> My understanding of the last Michael comment is to let the sys-admin delete
> the remaining user/group himself, right?
Yes, you should not remove the user, the user may only be removed if your 100.1%
sure that no files owned by that user will be left around, which in this case we
aren't actually we are pretty sure that files will be left around, so the
userdel must be removed from the spec file.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 9 months