[Bug 187569] Review Request: xfce4-mailwatch-plugin
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xfce4-mailwatch-plugin
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187569
bugzilla(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
QAContact|fedora-extras- |fedora-package-
|list(a)redhat.com |review(a)redhat.com
fedora.wickert(a)arcor.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution| |NEXTRELEASE
------- Additional Comments From fedora.wickert(a)arcor.de 2006-05-05 15:52 EST -------
Thanks fpr the review, Kevin.
Imported and build for FC-4 and FC-5. Rawhide is hosed ATM. Closing.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years
[Bug 188542] Review Request: hylafax
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: hylafax
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188542
fedora.wickert(a)arcor.de changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|fedora.wickert(a)arcor.de |bugzilla-sink(a)leemhuis.info
OtherBugsDependingO| |177841
nThis| |
------- Additional Comments From fedora.wickert(a)arcor.de 2006-05-05 14:04 EST -------
Sorry it took so long. The good thing about this is that I had enough time to
really test your package. Hylafax works prefectly here together with a
capi4hylafax package I rolled. Still I don't have a analog modem to test.
GOOD:
- Source matches upstream now
$ md5sum ~/downloads/hylafax-4.3.0.1.tar.gz (from osdn.sf.net)
30f6e56629f6a0ff40846be30a4f4ab8 /home/chris/downloads/hylafax-4.3.0.1.tar.gz
$ md5sum ~/Desktop/hylafax-4.3.0.1.tar.gz (from SRPM)
30f6e56629f6a0ff40846be30a4f4ab8 /home/chris/Desktop/hylafax-4.3.0.1.tar.gz
- License field ok
- explicit dependency on libtiff removed
BAD:
- still can't build this on my Core 5 machine, only mock succeeds. pkg-config
still looks in /usr/local/..
- rpmlint errors in detail: RPM (build in mock from your srpm):
$ rpmlint hylafax-4.3.0.1-1.fc5.i386.rpm | sort
E: hylafax executable-marked-as-config-file /etc/cron.daily/hylafax
E: hylafax executable-marked-as-config-file /etc/cron.hourly/hylafax
E: hylafax executable-marked-as-config-file /etc/rc.d/init.d/hylafax
safe to ignore
E: hylafax invalid-soname /usr/lib/libfaxserver.so.4.3.0.1 libfaxserver.so
E: hylafax invalid-soname /usr/lib/libfaxutil.so.4.3.0.1 libfaxutil.so
ok for me, I don't see a reason for changing this and for splitting out 2
symlinks into a seperate devel-package.
E: hylafax non-executable-script /var/spool/hylafax/bin/notify.awk 0444
is this on purpose? If not fix it upstream.
ok then
E: hylafax non-readable /var/spool/hylafax/etc/hosts.hfaxd 0600
E: hylafax non-standard-dir-perm /var/spool/hylafax/archive 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/docq 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/doneq 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/pollq 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/sendq 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/tmp 0700
due to ownership of uucp, safe to ignore. Nevertheless I suggest the other dirs
in /var/spool/hylafax to be owned by root.
E: hylafax script-without-shellbang /usr/sbin/faxsetup.linux
ignore or fix upstream
W: hylafax devel-file-in-non-devel-package /usr/lib/libfaxserver.so
W: hylafax devel-file-in-non-devel-package /usr/lib/libfaxutil.so
still no reason for a sepate -devel package IMO
W: hylafax incoherent-version-in-changelog 4.2.5.6-1 4.3.0.1-1.fc5
make sure the version field and changelog are matching. Please insert a blank
line after every changelog entry. ;)
W: hylafax non-conffile-in-etc /etc/hylafax/faxcover_example_sgi.ps
safe to ignore, otherwise mark this file as %config
SRPM:
rpmlint ../hylafax-4.3.0.1-1.src.rpm
E: hylafax no-%clean-section
IMHO you should replace
[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
with a simple
rm -rf $RPM_BUILD_ROOT
Your version is safer for other systems but this is a fedora package after all.
Anyway: I realized I'm not allowed to review your package. You are a first
timer, I'm not a sponsor. "The primary Reviewer can be any current package
owner, unless the Contributor is a first timer."
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines#head-e1a114b2349...
So I have added the review to the FE-NEEDSPONSOR tracker. You will have to wait
fore someone to sponsor you. Sorry, there's nothing I can do for you ATM.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years
[Bug 188176] Review Request: gauche-gtk - Gauche extension module to use GTK
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gauche-gtk - Gauche extension module to use GTK
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188176
------- Additional Comments From paul(a)city-fan.org 2006-05-05 10:01 EST -------
(In reply to comment #15)
> (In reply to comment #13)
> > So perhaps it's gtkglext-1.0.pc or gdkglext-x11-1.0.pc that should require
> > pangoft2 or pangoxft?
> Hmm, does anybody see any direct dependency between gtkglext and pangoft2 or
> pangoxft?
>
> At least, I don't see any, so I am inclined to think there might be a missing
> dep anywhere underneath. Or am I missing something?
As it happens, I think Gérard has done exactly the right thing.
This package is explicitly calling for ft2 support by including pango/pangoft2.h
from glgd.h. This only happens if the --enable-glgd-pango option is passed to
the configure script, and HAVE_GLGD_PANGO gets set. So it's this client, and not
a problem stemming from a missing dep somewhere down the tree.
If there's a bug, I suggest that it's that --enable-glgd-pango in this package
should also pull in the pangoft2 pkgconfig file for include directory settings.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years
[Bug 188176] Review Request: gauche-gtk - Gauche extension module to use GTK
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gauche-gtk - Gauche extension module to use GTK
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188176
------- Additional Comments From rc040203(a)freenet.de 2006-05-05 09:39 EST -------
(In reply to comment #13)
> So perhaps it's gtkglext-1.0.pc or gdkglext-x11-1.0.pc that should require
> pangoft2 or pangoxft?
Hmm, does anybody see any direct dependency between gtkglext and pangoft2 or
pangoxft?
At least, I don't see any, so I am inclined to think there might be a missing
dep anywhere underneath. Or am I missing something?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years
[Bug 188176] Review Request: gauche-gtk - Gauche extension module to use GTK
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gauche-gtk - Gauche extension module to use GTK
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188176
------- Additional Comments From paul(a)city-fan.org 2006-05-05 09:01 EST -------
(In reply to comment #12)
> However, this means, that there is a bug in the pkg-config for
> pango: it returns only -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/include, but since the pango header file
> pangofc-font.h includes ft2build.h, the include path for freetype
> must be added too.
I thought it would be something along those lines but was a bit confused by the
fact that pango-devel includes five .pc files, and the pangoft2.pc and
pangoxft.pc files do have the necessary include path.
So perhaps it's gtkglext-1.0.pc or gdkglext-x11-1.0.pc that should require
pangoft2 or pangoxft?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
18 years