Fri, Jan 08, 2016 at 04:29:15PM CET, jtluka(a)redhat.com wrote:
Fri, Jan 08, 2016 at 02:48:20PM CET, jtluka(a)redhat.com wrote:
>Fri, Jan 08, 2016 at 01:38:03PM CET, jiri(a)resnulli.us wrote:
>>From: Jiri Pirko <jiri(a)mellanox.com>
>>
>>Signed-off-by: Jiri Pirko <jiri(a)mellanox.com>
>>---
>> lnst/Common/TestsCommon.py | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>>diff --git a/lnst/Common/TestsCommon.py b/lnst/Common/TestsCommon.py
>>index accb6b8..817d747 100644
>>--- a/lnst/Common/TestsCommon.py
>>+++ b/lnst/Common/TestsCommon.py
>>@@ -142,5 +142,9 @@ class TestGeneric(NetTestCommandGeneric):
>> bg_id = " bg_id: %s" % self._command["bg_id"]
>> else:
>> bg_id = ""
>>- cmd = "%-9s%s%s" %(cmd_type, cmd_val, bg_id)
>>+ if "desc" in self._command:
>>+ desc = " desc: \"%s\"" %
self._command["desc"]
>>+ else:
>>+ desc = ""
>>+ cmd = "%-9s%s%s%s" %(cmd_type, cmd_val, bg_id, desc)
>> return cmd
>>--
>>2.4.3
>>
>
>This will affect only test modules. I'm sure we want to have this for
>all commands and not only test modules.
>_______________________________________________
>LNST-developers mailing list
>lnst-developers(a)lists.fedorahosted.org
>https://lists.fedorahosted.org/admin/lists/lnst-developers@lists.fedorahosted.org
NACK.
I discussed this with Ondrej and we agreed that it's better to print it
like this:
INFO: task: 1
INFO: host 1: exec cmd: "sleep 1" PASS
desc: "short sleep to give some time to settle"
instead of having the "desc" on the same line as "cmd:"
I'll send a patch.
Okay. Looking forward to it :)