From: Ondrej Lichtner olichtne@redhat.com
Should be {} instead of None since this is automatically passed to the _from_dict() method of a Parameters instance. This affects recipes where we dynamically connect to machines as part of the recipe itself - for example guest vms created during the recipe.
Signed-off-by: Ondrej Lichtner olichtne@redhat.com --- lnst/Controller/Machine.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lnst/Controller/Machine.py b/lnst/Controller/Machine.py index f63fd6f..10e0fdc 100644 --- a/lnst/Controller/Machine.py +++ b/lnst/Controller/Machine.py @@ -45,7 +45,7 @@ class Machine(object): """
def __init__(self, m_id, hostname, msg_dispatcher, ctl_config, - libvirt_domain=None, rpcport=None, security=None, pool_params=None): + libvirt_domain=None, rpcport=None, security=None, pool_params={}): self._id = m_id self._hostname = hostname self._mapped = False
On Wed, Oct 07, 2020 at 10:56:31AM +0200, olichtne@redhat.com wrote:
From: Ondrej Lichtner olichtne@redhat.com
Should be {} instead of None since this is automatically passed to the _from_dict() method of a Parameters instance. This affects recipes where we dynamically connect to machines as part of the recipe itself - for example guest vms created during the recipe.
Signed-off-by: Ondrej Lichtner olichtne@redhat.com
lnst/Controller/Machine.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lnst/Controller/Machine.py b/lnst/Controller/Machine.py index f63fd6f..10e0fdc 100644 --- a/lnst/Controller/Machine.py +++ b/lnst/Controller/Machine.py @@ -45,7 +45,7 @@ class Machine(object): """
def __init__(self, m_id, hostname, msg_dispatcher, ctl_config,
libvirt_domain=None, rpcport=None, security=None, pool_params=None):
libvirt_domain=None, rpcport=None, security=None, pool_params={}): self._id = m_id self._hostname = hostname self._mapped = False
-- 2.28.0
Since this is a very simple patch, I'm going ahead with pushing this to master.
-Ondrej
lnst-developers@lists.fedorahosted.org