On Fri, Mar 08, 2019 at 09:53:49AM +0100, Jiri Pirko wrote:
Wed, Feb 27, 2019 at 09:05:57AM CET, liuhangbin(a)gmail.com wrote:
>When we add a port to team via teamdctl, some drivers do not support changing
>mac address after dev opened, which would lead to the failure of
>port_obj_create().
Where exactly this failure happens?
for LACP mode:
port_obj_create()
- port_priv_init_all()
- lacp_port_added()
- lacp_port_set_mac()
>@@ -203,6 +205,7 @@ static int port_obj_create(struct teamd_context *ctx,
> teamd_event_port_removed:
> teamd_event_port_removed(ctx, tdport);
> list_del:
>+ teamd_port_remove(ctx, tdport);
This is not in sync with port_obj_remove() :/
Oh, I will add this in port_obj_remove()
Thanks
Hangbin