libteam March 2022

libteam@lists.fedorahosted.org

2 discussions

[PATCH] options: move option temporary check after the err check
by Xin Long 27 Jun '22

27 Jun '22

option is set only if err returned from update_option() is 0, so check err first before checking option->temporary. Otherwise, it may results in a dereference of an undefined pointer value. Fixes: 8180763d6f82 ("libteam: always add newly created option to option list") Signed-off-by: Xin Long <lucien.xin(a)gmail.com> --- libteam/options.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libteam/options.c b/libteam/options.c index 71cc99e..51e233e 100644 --- a/libteam/options.c +++ b/libteam/options.c @@ -688,10 +688,10 @@ static int local_set_option_value(struct team_handle *th, err = update_option(th, &option, opt_id, opt_type, data, data_len, true, true); - if (option->temporary) - destroy_option(option); if (err) return err; + if (option->temporary) + destroy_option(option); return 0; } -- 2.27.0

2 1

Release anytime soon?
by J Farkas 27 Jun '22

27 Jun '22

Hi! I'm using the latest code from github, and I would also like to have it packaged for a distribution which does not have libteam yet - https://github.com/void-linux/void-packages/pull/33028 They are making a point that it's preferable using a proper upstream release. As far as I can see, the commits since 1.31 appear somewhat important. On the other hand, even the latest github changes are somewhat old, so I can't see anything unstable about it. For the benefit of a cleaner packaging, are there any plans to make a numbered release anytime soon? Janos

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

libteam March 2022