kernel.On Fri, Jul 28, 2017 at 5:23 PM, Adrian Reber <adrian(a)lisas.de> wrote:
On Fri, Jul 28, 2017 at 03:30:07PM +0100, Peter Robinson wrote:
> On Fri, Jul 28, 2017 at 3:01 PM, Adrian Reber <adrian(a)lisas.de> wrote:
> > Bugzilla:
> >
https://bugzilla.redhat.com/show_bug.cgi?id=1475719
> > Fedora - Add new package CRIU for Docker on z Systems
> >
> > Koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20844822
> >
> > Testing:
> > The kernel from koji was used to run the CRIU test suite (zdtm)
> > on a RHEL s390x system. The kernel was started using kexec.
> >
> > # ./zdtm.py run -a --keep-going
> > [...]
> > ################### 1 TEST(S) FAILED (TOTAL 317/SKIPPED 34)
####################
> > * zdtm/static/socket-tcp-nfconntrack(h)
> > ##################################### FAIL
#####################################
> >
> > The are always tests which can fail in the CRIU test suite and this one
> > fails during the following command:
> > # iptables -w -A INPUT -i lo -p tcp -m state --state NEW,ESTABLISHED -j
ACCEPT
> > iptables: No chain/target/match by that name.
> >
> > So this failure seems to be unrelated to the actual checkpointing feature of
> > CRIU.
> >
> > Signed-off-by: Adrian Reber <adrian(a)lisas.de>
> > ---
> > kernel-s390x-debug.config | 3 ++-
> > kernel-s390x.config | 3 ++-
> > 2 files changed, 4 insertions(+), 2 deletions(-)
>
> This is incorrect, these files are auto generated, you need to change
> the appropriate option within the baseconfig tree and then run
> ./build_configs.sh
>
> $ grep -R CONFIG_CHECKPOINT_RESTORE baseconfig/
> baseconfig/x86/x86_64/CONFIG_CHECKPOINT_RESTORE:CONFIG_CHECKPOINT_RESTORE=y
> baseconfig/CONFIG_CHECKPOINT_RESTORE:# CONFIG_CHECKPOINT_RESTORE is not set
> baseconfig/powerpc/powerpc64le/CONFIG_CHECKPOINT_RESTORE:CONFIG_CHECKPOINT_RESTORE=y
> baseconfig/arm/CONFIG_CHECKPOINT_RESTORE:CONFIG_CHECKPOINT_RESTORE=y
Ah, was not aware of that. Thanks. So I change the files in baseconfig
and commit the generated file into git as well?
Correct:
cp baseconfig/x86/x86_64/CONFIG_CHECKPOINT_RESTORE baseconfig/s390x/
git add baseconfig/s390x/CONFIG_CHECKPOINT_RESTORE
./build_configs.sh
Add changelog to kernel.spec
Commit