On 01-11-17 20:34, Laura Abbott wrote:
On 11/01/2017 11:09 AM, Hans de Goede wrote:
> Hi All,
> I'm working on trying to improve the OOTB power-consumption
> of Fedora Workstation on laptops.
> One of the easy wins here is setting snd_hda_intel.power_save=1,
> which saves about 0.4W which given that modern laptops idle at
> around 6-8W is a significant saving.
> I've asked the upstream kernel devs if there are any downsides
> to setting SND_HDA_POWER_SAVE_DEFAULT=1 and I got a reply that
> this should be fine and that OpenSUSE Tumbleweed is already
> doing this.
> So unless there are any objections I would like to change this
> option to 1 starting with 4.14 kernel. Is that ok ?
I'm always a bit uneasy about enabling hardware power saving
since it rarely seems to be done correctly but as Peter pointed
out it's easy to revert if something goes wrong. Having the
endorsement of upstream is also good since it means they should
Enabling for 4.14 sounds like a good plan. Did you intend for
this to end up in stable releases on rebase?
That was my original intention yes. But now that you explicitly
ask I guess that we may want to hold off on that and just
make the change for rawhide / F28. I will try to get the
change committed to the master branch today (otherwise
I will do it Monday). I will leave it up to you if you also
make the change to the stable releases on rebase.