Lo!
Am 05.10.20 um 22:36 schrieb GitLab Bridge on behalf of dzickusrh:
From: Don Zickus <dzickus(a)redhat.com>
This in spirit reverts 0409b218390b564c44dd0181c5d0fe177d4c6bc3
and converts the broken out Red Hat patches back into a single diff.
I don't like that idea. And as mentioned a few month ago: I think it's
violating the Fedora packaging guidelines, see first para of this:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_applying_patches
Hence I think you should get this vetted by the Fedora packaging comittee
or work with them to update the guidelines, as there were reasons why they
were written like that.
Anyway, I didn't give this a try, but I have a comment on this line:
+git log --no-merges --pretty=oneline --no-decorate master..
$EXCLUDE_FILES \
+ > $SOURCES/Patchlist.changelog
Would be nice if those could be links to the commits in question,
as that makes it easy to look at them. How about something like this:
$ git log --no-merges --pretty=oneline --no-decorate master..$EXCLUDE_FILES | sed
's!^!https://gitlab.com/cki-project/kernel-ark/-/commit/!; s! !\n !; s!$!\n!' >
$SOURCES/Patchlist.changelog
Then something (note: I did it with some random git tree I had at hand,
not with kernel-ark, hence the URLs won't work) like this
a755240762dd07bb48cf3e561b1e6cfa894f9178 docs: reporting-bugs: add SPDX tag and license
hint, remove markers
42d0e4956abf7ea2b0ea15f56afb1720a11739f1 docs: reporting-bugs: explain things could be
easier
aac1d02c1ca7d4a20dfe47ae6f824e1091c654e3 docs: reporting-bugs: explain why users might get
neither reply nor fix
Becomes
https://gitlab.com/cki-project/kernel-ark/-/commit/a755240762dd07bb48cf3e...
docs: reporting-bugs: add SPDX tag and license hint, remove markers
https://gitlab.com/cki-project/kernel-ark/-/commit/42d0e4956abf7ea2b0ea15...
docs: reporting-bugs: explain things could be easier
https://gitlab.com/cki-project/kernel-ark/-/commit/aac1d02c1ca7d4a20dfe47...
docs: reporting-bugs: explain why users might get neither reply nor fix
Ciao, Thorsten