On Fri, 13 Nov 2020 21:12:19 -0000, GitLab Bridge on behalf of bcrocker wrote:
- arch="$(echo "$file" | sed
"s/$PACKAGE_NAME-\([^-]*\).*.config/\1/")"
+ arch="${file/$PACKAGE_NAME-/}"
+ arch="${arch/-*/}"
Just noting this is not equal. It doesn't seem to matter in practice,
though, so go on with this, it's a good change.
- test ! -e $path && echo "$value" >
$path && continue
+ test ! -e "$path": && echo "$value" >
"$path" && continue
The colon seems to be a typo. This introduces a bug, the echo will
always trigger.
- for f in $(ls -1 $WORK/kernel*.config)
+ for f in "$WORK"/kernel*.config
This behaves differently when there's no kernel*.config. Are you sure
it cannot happen? It probably can't but please double check.
- make ARCH=$arch listnewconfig 2>/dev/null | grep -E
'CONFIG_' | cut -d'#' -f1 > $WORK/$config
+ make ARCH="$arch" listnewconfig 2>/dev/null | grep -E
'CONFIG_' | cut -d'#' -f1 > $WORK/"$config"
Curious, why the tool you're using is not flagging $WORK as a candidate
for quotation?
Jiri