From: Ben Crocker <bcrocker(a)redhat.com>
SC2231: Quote expansions in this for loop glob to prevent wordsplitting.
SC2086: Double quote to prevent globbing and word splitting.
Signed-off-by: Ben Crocker <bcrocker(a)redhat.com>
---
redhat/update_scripts.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/redhat/update_scripts.sh b/redhat/update_scripts.sh
index 5c3dbaeb9459..9196e795a84c 100755
--- a/redhat/update_scripts.sh
+++ b/redhat/update_scripts.sh
@@ -1,12 +1,12 @@
#!/bin/sh
-if [ -z $1 ]; then
+if [ -z "$1" ]; then
exit 1
fi
-TARGET=$1
+TARGET="$1"
-for i in $RPM_SOURCE_DIR/*.$TARGET; do
+for i in "$RPM_SOURCE_DIR"/*."$TARGET"; do
NEW=${i%.$TARGET}
- cp $i $NEW
+ cp "$i" "$NEW"
done
--
GitLab