On Wed, Apr 15, 2020 at 5:32 AM Thorsten Leemhuis <fedora(a)leemhuis.info> wrote:
Am 15.04.20 um 00:37 schrieb Jeremy Cline:
> On Tue, 2020-04-07 at 15:33 +0000, Jeremy Cline wrote:
>> On Wed, 2020-03-11 at 16:40 +0000, Jeremy Cline wrote:
>>
>> Just a note folks, the plan is to do this starting next week after
>> the close of the v5.7 merge window.
>
> Okay, this is now done. You may notice a number of stale options made
> their way back into the config files, it's on my to-do list to clean
> this up assuming there aren't any larger fires this week.
There is one thing I really dislike about the scheme (one it didn't
notice when I took a brief look at it weeks ago; sorry): There are no
individual patches anymore in dist-git/the srpm and that afaics violates
the packaging guidelines.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_applying_patches
```
The files MUST then be checked into the Fedora Package revision control
system […]. Storing the files in this way allows people to use standard
tools to visualize the changes between revisions of the files and track
additions and removals without a layer of indirection […].
```
There are other rules in the patch section that afaics are violated.
Were those violation discussed and blessed by the
Fedora Packaging Committee or FESCo?
I don't think the split out patches "rule" is being violated here.
They changed the source tarball to one generated from the git tree and
they don't have any patches at the dist-git level at all. Several
other packages in Fedora already do this, such as anaconda.
I for one would dislike such an exception, because I sometimes look
at
kernel source packages from other dists and it is always annoying when I
can't easily see individual patches. It also makes it way harder for
users to remove one certain patch that Fedora applied for testing or
other reasons.
So you you maybe change the scheme so individual patch files land in the
src.rpm?
Is there a reason you can't do that in the source git tree instead?
P.S.: The "--with-vanilla" build option afaics doesn't
work anymore, as
patch-%{rpmversion}-redhat.patch and linux-kernel-test.patch are always
applied.
I'm not sure --with-vanilla will exist at all with the changes here.
josh