On Fri, Jun 05, 2020 at 05:19:22PM +0100, Peter Robinson wrote:
>
> Well, I don't mind a few more mails, I already get a lot and they make
> not much of a difference, *if* they are useful somehow. But to be useful
> they are currently to hard to parse/understand: you have to scroll down
> quite far and at the same time look closely to not miss the interesting
> part, as that is only three lines long per symbol:
> ```
> +++ b/redhat/configs/common/generic/CONFIG_SENSORS_AMD_ENERGY
>
> @@ -0,0 +1 @@
>
> +# CONFIG_SENSORS_AMD_ENERGY is not set
> ```
>
> At the same time one IMHO relevant context information is missing
> afaics: how did the Fedora kernel maintainers set this option?
>
> IOW: I'd even like the mails if they would look more like this, where
> the interesting part is at the top:
>
> ```
> Subject: New configs in drivers/hwmon
>
> Set newly introduced config symbols like this in kernel-ark:
>
> * set CONFIG_SENSORS_AMD_ENERGY to 'not set' for RHEL ('m' in
Fedora)
> * set CONFIG_SENSORS_MAX16601 to 'not set' for RHEL ('not set' in
Fedora)
>
> <Symbol description/>
> <all the other stuff needed, including the the slightly annoying
> standard header that starts with 'As a reminder, the ARK configuration
> flow involves', and obviously the diff itself/>
> ```
>
>
> Maybe even add the config symbol to the subject if it doesn't get to
> long that way.
>
> That would makes these mails a lot more useful and easier to review for
> me. And I guess it's the same for RH partners and customers as well.
Yes, I agree with that summary, it would make it more useful for me too.
Thanks Knurd, Peter! I filed this as an issue:
https://gitlab.com/cki-project/kernel-ark/-/issues/29
Hopefully in a couple of weeks when things settle down, we can look into it.
Most of it is automated scripts so it is just bash magic or looks like awk
magic: redhat/gen_configs_patches.sh and redhat/commit_template.
Cheers,
Don