On Thu, 2012-08-23 at 13:57 -0700, Roland McGrath wrote:
> Suggestions for a better description welcome. Originally I had:
> "elf_getshdr now doesn't sometimes assert on non-mmaped ELF files after
> calling elf_cntl(ELF_C_FDREAD)."
We haven't usually added NEWS items for bug fixes.
But this was a particularly nasty and confusing one, so I do want to
mention it explicitly so people who stumbled over it will notice.
> It will be fine. [...]
No, it won't. You are missing the security issues I'm talking about.
Again, you give no specifics, and you are snipping my response why it
isn't one. I did think about it. Also like I said I would, I asked
others with dwz experience to take a look and they also didn't know what
you are implying. You make it really hard to help you fix issues.
(It's also completely wrong API layering.) Sorry I gave you a
impression of approval about this. I was not thinking very clearly
at the Cauldron.
:) You were the one suggesting it was better to not have public
interfaces and keep the implementation details hidden and let
libdw/libdwfl directly interface if necessary. I do agree with that. And
as the patch history shows that is how we did it in the end. I am
interested in your improvements of course. But I have not seen them.
I object strenuously to making a release with this
code in it. We can discuss the details when I'm back from vacation.
If you feel so strongly about it then I can certainly disable it by
default. But you are not being very helpful. You cannot just ignore
discussions about patches for months and just handwave about issues
which you then fail to be specific about or even offer alternatives for.
Hope your vacation is refreshing and we will have a bit more productive