elfutils-devel December 2010

elfutils-devel@lists.fedorahosted.org

6 participants
8 discussions

[patch] Fix elf_getdata_rawchunk false error
by Jan Kratochvil 11 Jan '11

11 Jan '11

Hi, if you run jankratochvil/gdbserver as: ./gdbserver 1234 corefile without this change it prints: ./gdbserver: Error reading note at core file offset 0x468 due to: 81 if (unlikely (size > elf->maximum_size 82 || (off64_t) (elf->maximum_size - size) < offset)) (gdb) p size > elf->maximum_size $6 = 0 (gdb) p (off64_t) (elf->maximum_size - size) < offset $7 = 1 (gdb) p offset $10 = 1128 (gdb) p (off64_t) (elf->maximum_size - size) $8 = -1369 (gdb) p elf->maximum_size - size $9 = 18446744073709550247 (gdb) p/x elf->maximum_size $11 = 0xffffffffffffffff In fact I believe Elf->maximum_size should be off64_t and not size_t as this way 32bit hosts cannot handle >2GB ELF files, can they? But as 32bit hosts are dead I did not try to do the more invasive change. OK to merge to master? It is now in <jankratochvil/pending>. No regressions on {x86_64,i686}-fedora13-linux-gnu. Thanks, Jan libelf/ 2010-12-19 Jan Kratochvil <jan.kratochvil(a)redhat.com> * elf_getdata_rawchunk.c (elf_getdata_rawchunk): Fix off64_t overflow when MAXIMUM_SIZE == ~0. --- a/libelf/elf_getdata_rawchunk.c +++ b/libelf/elf_getdata_rawchunk.c @@ -78,8 +78,8 @@ elf_getdata_rawchunk (elf, offset, size, type) return NULL; } - if (unlikely (size > elf->maximum_size - || (off64_t) (elf->maximum_size - size) < offset)) + if (unlikely (offset < 0 || offset + (off64_t) size < offset + || offset + size > elf->maximum_size)) { /* Invalid request. */ __libelf_seterrno (ELF_E_INVALID_OP);

2 3

FYI <jankratochvil/gdbserver> gdbserver-for-core branch
by Jan Kratochvil 06 Jan '11

06 Jan '11

Hi, FYI there is now branch <jankratochvil/gdbserver> containing a mostly done <src/gdbserver.c> (except registers NOTEs) as a gdbserver only for core files. FSF gdbserver cannot load core files. Created for ABRT purposes. (I hope it is OK to create the <jankratochvil/*> branch(es).) Regards, Jan

3 7

dwarf_output overview
by Roland McGrath 05 Jan '11

05 Jan '11

https://fedorahosted.org/elfutils/wiki/DwarfOutput is still accurate in its basic description about the collector (class dwarf_output_collector). We don't really need to get into right now why it's a separate object from dwarf_output. For uses in the time being, we'll use one collector with one dwarf_output for one input file. The simple attribute values, and some bits of interface glue, are shared via template use from dwarf_data, with dwarf_edit. The only difference is that in dwarf_output we never have mutable versions of thse objects, only const pointers/references to immutable copies sitting in the collector. Whereas dwarf_edit has mutable containers, there is no modification you can do to a dwarf_output object once it's created. Instead, like dwarf_edit you can copy-construct a dwarf_output object from any dwarf-compatible class (i.e. dwarf, dwarf_edit, or dwarf_output)--this is the only way to get a nonempty dwarf_output object. The dwarf_output constructor takes two arguments, unlike the simple dwarf_edit constructor. The second argument is the collector object. This actually uses a second helper object, whose only purpose is to live as long as copy construction is going on. That's dwarf_output::copier, which is actually dwarf_output::copier<input> parameterized by the particular top-level input type (dwarf or dwarf_edit). (This will one day be exposed outside dwarf_output for some of the same cases where a separate collector is really useful, but we won't get into that now.) The copy construction is doing the whole file, or at least a whole CU, from the root of the tree down to the leaves and all attribute values. The copier holds some bookkeeping and some caches during that process. The essential method is that the tree from the CU on down has its debug_info_entry objects constructed recursively, with debug_info_entry::attr_value objects being constructed for each node. Each attr_value on up to each debug_info_entry is "constructed" by finding its exact match stored in the collector, inserting it only if it's not already there, and then returning the pointer (i.e. actually all C++ references) to the (now) existing data structure. The copier's part in this is twofold. First, there is some simple caching related to copying the simple attribute values. (All the value types other than references are "simple".) Second, there is all the hairy bookkeeping for the complexity brought on by references. The copier's caching is a simple optimization, so I'll describe it first. This is for strings, identifier strings (which we distinguish from other strings, though they are just strings in DWARF), and source files. In one input file, even across many CUs (because of linker SHF_MERGE|SHF_STRINGS merging), every DW_AT_name "foobar" will point to point to the same "foobar" in the .debug_str table. Likewise, a dwarf::source_file object that represents a source file from the .debug_line table is what we get for every DW_AT_decl_file attribute on the input tree, but there will be many DIEs with that attribute pointing to the same file entry (same index into the CU's .debug_ling table, so getting the same dwarf::source_file again and again). Hence, we expect to see the actual same pointer (in a dwarf reader object, really the same pointer into the mmapped DWARF file data) appearing many times in the input tree's attr_values. Matching pointers you've seen before is quicker than matching string values you've seen before. So the copier keeps maps keyed by these string (and file entry) pointers into the input data, to find exact attr_value's already found/created to match other instances of the same input string (or file entry). (This sped things up a fair bit when I added it, though I don't recall the details.) For all the simple attribute values the method is simple. For each flavor of attr_value, the collector holds a set of values seen before. The subr::value_set container type is used for this. It's based on the STL unordered_set, which is a hash table where we supply the key type and the hash and comparison functions on that type. In these sets, our key types are dwarf_output::value::value_*, which are the flavor-specific subtypes that an attr_value actually points to. So, each of those types has to provide an integer hash function (a "hasher" inner class) and a comparison function (operator==). The copier does a set insertion of the input value object, which installs a new dwarf_output::value::value_foobar object if none matched, or doesn't if one did, and then produces an attr_value that points to that. Note that since this is the only way any dwarf_output::attr_value objects can ever get created, within one dwarf_output object (really, one collector), simple pointer equality is exactly correct as a semantic equality check for the non-reference attribute values. A corollary is that just this pointer value itself can be used as the hash value for the attr_value object (a perfect hash function). If there are no reference attributes to consider, then it proceeds from the bottom up in the same straightforward way. That is, the entire map of attributes (considered as a sequence of <int name, attr_value> pairs in a canonical name-keyed order) can be hashed together to get a hash value for the attributes container. Then a leaf node can combine the tag into the that hash value to get a hash value for the whole DIE. Then, a sequence of sibling leaf nodes' hash values are combined to form a hash value for the whole children container. Then that hash value is combined with the tag and the attribute map hash value to form a hash value for the whole DIE. Then on up. So this is what we do. The simple attribute values are hashed on the actual values (string data, integer values, etc.), and then those pointer values along with the attribute name (integers) in a canonical order are combined with the DIE tag into a single integer hash. The _m_attr_sets set (i.e. hash table) holds these <attribute map, tag integer> pairs. Then children vectors, starting with the empty vector for leaf DIEs, are hashed into the _m_broods set. (The empty vector has hash value zero.) Finally, a dwarf_output::debug_info_entry just consists of pointers to the attributes map and children vector, and the DIE tag integer. We just combine those two pointer values and the tag to make the integer hash of the debug_info_entry object itself. _m_unique holds the set of unique debug_info_entry objects. So, a leaf DIE gets created with an attributes map pointer and a pointer to the one and only empty children vector object. Then a non-empty children vector is simply a vector of pointers to debug_info_entry objects like that one. Like for the other sets, a pointer to a particular debug_info_entry in the collector serves as a perfect integer hash, since by definition pointer equality of the debug_info_entry object exactly maps to semantic equivalence. So, the children vector is a simple container of pointers, and the vector itself has a hash value made just by combining the pointer values as so many constituent integer hash values. So, it's like that when no attribute values are references. The exact control flow between the constructors of the dwarf_output inner classes and dwarf_output::copier is extremely hairy. But the extreme template weirdness is mostly just to get the copier pointer passed down the levels of constructors to where it calls an add_* method on the copier. It's there, and the collector methods they call, where the real work happens. It's even like that when there are some references, for simple cases. So, start with a completely simple leaf node: <base_type name="int" byte_size=0x4 encoding=signed/> That's all simple, so its attribute values, map, empty children vector, debug_info_entry will all be hashed and inserted in the collector as above. Now there is a known debug_info_entry pointer for that DIE. Next, say you are copying: <variable name="x" type="#int" location=.../> The various simple attributes all resolve to known value pointers. The type="#int" attribute is the only reference value, pointing to the DIE we just mentioned. Since that's a fully resolved known DIE now, we can in fact treat it the same way as we treat simple attribute values. Along with the one debug_info_entry object in the collector, we only need to have exactly one dwarf_output::value::value_reference object that points to it. So here, that value object pointer is perfect hash and equality test for a reference attribute that refers to a DIE identical to the "int" above, just like the value object pointers for the simple value flavors are. If that's all there were to do, it would be easy. Of course, there are circular references. So say we have: <structure_type id="t1" name="list"> <member name="next" type="#p1"/> </structure_type> <pointer_type id="p1" type="#t1"/> Now, the structure_type's own attribute map is simple, so that hashes up nicely. But, the member's attribute map includes a circular reference. So, what we do is still hash up the whole attribute map, but use zero as the hash value for the reference value. Now <member/> as a whole has a hash value that contributes to the children vector hash value, and that contributes to the structure_type's overall hash value. Two entries that look like this but have different references in the type attribute--but both circular references in the overall graph--would have the same hash value. So when comparing those, we'd get a hash collision and have to do a full comparison. That would find the two attribute maps identical, so look at the two children vectors. The corresponding member entries' attribute maps would then be compared for equivalence, the non-reference attribute values (i.e. name="next") matching by simple pointer comparison. But for the reference, we have to do a ref-walking comparison in the manner of dwarf_comparator. This plan means that for <pointer_type type="something circular"/> and <reference_type type="something circular"/>, we'll actually have dozens to thousands of entries with the same hash value--basically every single pointer_type to a nontrivial class/struct is a hash collision with every other. If that's the plan, then the ref-walking comparisons we do have to be very well-optimized. We'll be doing many, many of them every time we come across another pointer_type entry in the input. Picayune as I've been, this is just the broad overview. It seems solid, and the obvious thing to do, up to the point of the plan for circular references. It's not entirely clear that having so many hash collisions in this approach is a reasonable way to go. But I don't know what a different plan would be for efficiently identifying equivalent subtrees in the presence of circular references. Most of the real complexity in the copier has to do with handling forward references in attributes, including circular references. Aside from the simple-value mapping caches I described earlier, everything else is pretty much just interface glue for making the dwarf_output constructors work. The possibility of forward references means we have to partially construct entries while waiting to resolve their references, so there are lots of internal data structures for that. In valid input data, a single entire (logical) CU tree has no dangling references. So all the partially-built tracking data structures only need to live (at most) during the construction of one compile_unit tree in the dwarf_output object. The only things that live longer in the copier are just caches keyed on parts of the input that might be shared across input logical CUs (like the strings, but also input DIEs--for when eventually reading compressed format input). For following the control flow, you can start at dwarf_output::copier::make_unit. You can read the classes it calls to see how it's all organized. (Note how at various levels, most of the actual work happens inside a foo_copier constructor.) For all of the entry-copying hair inside dwarf_output::copier, I think it will be easiest to just answer questions as you read through the code, rather than trying to describe a structure and a plan. I can explain it all piece by piece, but at this point will largely be recovering the knowledge from re-reading the code anyway, so we can read it together. How that all works is quite ad hoc (and about the third generation of how I organized it), and I probably couldn't articulate an overall algorithm it is implementing. There is: #if 0 // Toggle this to enable massive debugging spew during construction. and making that 1 will get you quite a lot of spew that may help get a handle on how the partial entry resolution control flow goes. The usual ways to drive a test of this is: tests/dwarf-print --output file For nontrivial CUs in the input file, the debugging spew is truly massive. Thanks, Roland

2 30

non-zero module bias for prelinked ET_EXEC in 0.150
by Josh Stone 05 Jan '11

05 Jan '11

Hi Roland, I discovered today that I was getting bad addresses for a simple systemtap probe, process("/bin/env").function("main"). I tracked it down to getting the module bias from dwfl_module_detdwarf, which AIUI should always be zero for ET_EXEC. When this file is prelinked, we're getting a non-zero bias. This is a regression from 0.149, apparently due to the address_sync logic added for the i386 REL->RELA fix. I'm on x86_64 this time, and that /bin/env is from coreutils-8.5-7.fc14.x86_64. Jakub said that the PT_LOAD heuristic should work fine for shared libraries, but suggested for ET_EXEC that it might work better to compute the bias from non-movable sections, or to parse the .gnu.prelink_undo section. I've attached readelf -WlS for prelinked and not, and for the .debug. I also uploaded those along with the actual binaries here: http://jistone.fedorapeople.org/env-prelink-issue/ Thanks, Josh

2 1

about libelf by example
by Fennec Cleric 04 Jan '11

04 Jan '11

Hi everyone, We are trying to make an ELF file (using Mr. Koshy's Libelf By Example code) on Fedora 13. However, after installing the headers and libelf, we are still having some issues. For one, our computer doesn't seem to find where this is: elf_setshstrndx(e, elf_ndxscn(scn)); If we take this line out (to see if it was the only missing item in our code), compile it and run it, we get that our code is unable to make an executable ELF file, but it says that there are no error messages. Has anyone had this issue in the past? Does anyone have any ideas on where we can get this method or how to fix this? Thank you so much for all of your help! EV and AK

3 2

qsort_r missing on some platforms
by Zach Welch 10 Dec '10

10 Dec '10

Howdy, I just tried to build the current elfutils Git repository and get the following errors. The missing qsort_r resulted from having an old version of the GNU C library (libc-2.7.so). I imagine the sign comparison may be related. gcc -D_GNU_SOURCE -DHAVE_CONFIG_H -DLOCALEDIR='"/scratch/zwelch/elfutils-install/share/locale"' -DDEBUGPRED=0 -DSRCDIR=\"/scratch/zwelch/elfutils/src\" -DOBJDIR=\"/scratch/zwelch/elfutils/src\" -I. -I.. -I. -I. -I../lib -I.. -I./../libelf -I./../libebl -I./../libdw -I./../libdwfl -I./../libasm -std=gnu99 -Wall -Wshadow -Werror -Wunused -Wextra -Wformat=2 -g -O2 -MT readelf.o -MD -MP -MF .deps/readelf.Tpo -c -o readelf.o readelf.c cc1: warnings being treated as errors readelf.c: In function 'sort_listptr': readelf.c:4360: error: implicit declaration of function 'qsort_r' readelf.c: In function 'print_debug_ranges_section': readelf.c:4566: error: comparison between signed and unsigned readelf.c: In function 'print_debug_loc_section': readelf.c:6337: error: comparison between signed and unsigned make[2]: *** [readelf.o] Error 1 For now, I simply went back to elfutils-0.146 tag (which builds fine on the same host and allows me to continue with my intended tasks). I would be happy to help produce or verify a fix that allows me to work with the master branch, but a workaround for the missing qsort_r function was not immediately obvious to me. -- Zach Welch CodeSourcery zwelch(a)codesourcery.com (650) 331-3385 x743

2 1

sharing_stack
by Roland McGrath 07 Dec '10

07 Dec '10

If you think your sharing_stack fix makes it good, then s/stackish/sharing_stack/ in dwarf and dwarf_tracker. That's the only way to get the code back in use. Doing so should reduce the memory footprint of dwarfcmp (and some of dwarf_output stuff) by a lot, and maybe help CPU use too. If that works without new regressions or strangeness, then it's all good. Thanks, Roland

2 2

g++-4.5 vs dwarf branch
by Mark Wielaard 01 Dec '10

01 Dec '10

Hi, I happily updated my machine to fedora 14 which comes with g++ 4.5.1. Unfortunately that g++ version doesn't like the dwarf branch libdw/c++ stuff. There seem to be three issues. I solved one and put that on the mjw/gcc45 branch. Reviews to see if it could be moved to the dwarf branch would be nice. - g++ 4.5 doesn't like to call constructors by name directly. This makes it impractical to have a class and a function that tries to call the constructor by the same name. So rename the various compile_units classes to compile_units_type. Leaving the function compile_units to return the correct instance type. (This is on the branch.) - std::pair<_T1, _T2>::second’ has incomplete type. This is strange. I haven't been able to reproduce it in a smaller setup. The error looks as follows: /usr/lib/gcc/x86_64-redhat-linux/4.5.1/../../../../include/c ++/4.5.1/bits/stl_pair.h: In instantiation of ‘std::pair<const elfutils::dwarf_output::debug_info_entry, elfutils::dwarf_output::die_info>’: /home/mark/src/elfutils/libdw/c++/dwarf_output:233:63: instantiated from here /usr/lib/gcc/x86_64-redhat-linux/4.5.1/../../../../include/c ++/4.5.1/bits/stl_pair.h:77:11: error: ‘std::pair<_T1, _T2>::second’ has incomplete type /home/mark/src/elfutils/libdw/c++/dwarf_output:146:12: error: forward declaration of ‘struct elfutils::dwarf_output::die_info’ Which doesn't make sense to me. The code it complains about is an invocation of vector<die_info_pair *>.end(). The following "patch" makes it go away. But I have no idea why, both code constructs seem to not actually use the pair directly: diff --git a/libdw/c++/dwarf_output b/libdw/c++/dwarf_output index 9e5c1f6..3a22b7a 100644 --- a/libdw/c++/dwarf_output +++ b/libdw/c++/dwarf_output @@ -230,8 +230,10 @@ namespace elfutils inline void set_hash () { _m_hash = 0; +/* for (_base::iterator i = _base::begin (); i != _base::end (); ++i) subr::hash_combine (_m_hash, (uintptr_t) *i); +*/ } inline children_type () {} @@ -411,7 +413,7 @@ namespace elfutils for the circular_reference case, below. */ virtual size_t hash () const { - return ref->identity (); + return 0; // ref->identity (); } }; - Last issue is the "swap" function from compile_units[_type]: libdw/c++/dwarf_output:566:7: error: no matching function for call to ‘elfutils::dwarf_output::compile_units_type::swap(elfutils::dwarf_output::compile_units_type)’ I am not clear where the swap function should have been defined. Cheers, Mark

2 5

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

elfutils-devel December 2010