On Thu, 2014-03-06 at 22:11 +0100, Jan Kratochvil wrote:
On Mon, 03 Mar 2014 15:31:27 +0100, Mark Wielaard wrote:
> --- a/libdwfl/elf-from-memory.c
> +++ b/libdwfl/elf-from-memory.c
[...]
> @@ -195,21 +200,28 @@ elf_from_remote_memory (GElf_Addr ehdr_vma,
> bool found_base = false;
> switch (ehdr.e32.e_ident[EI_CLASS])
> {
The return value could be documented.
> - inline void handle_segment (GElf_Addr vaddr, GElf_Off offset,
> - GElf_Xword filesz, GElf_Xword align)
> + inline bool handle_segment (GElf_Addr vaddr, GElf_Off offset,
> + GElf_Xword filesz, GElf_Xword palign)
Added documentation for both handle_segments nested functions.
I agree with the patch.
Pushed with extra docs.
Thanks,
Mark