On Wed, 2015-03-18 at 13:42 -0700, Roland McGrath wrote:
Special-casing by name is obviously wrong. Can you characterize the
case
you're trying to address more precisely?
It is obviously wrong, but sadly the only thing that I believe we have
to go on. The case this is trying to fix is when the linux-gate/vdso is
dumped into the core file but not used anyway because it contains a
build-id. The current code assumes that when we have a build-id we will
always be able to find it on disk. That is in general better since it
might be that what got dumped into the core file might be incomplete,
might not contain shdrs, etc. And if we have a build-id we usually have
a good way to find the actual full ELF file on disk. But that isn't the
case for linux-gate/vdso since a) it is small and fits in one page and
b) often there isn't a real way to find a file image even by build-id.
O. Now that I have written that down. I see a better heuristic. We
actually know the size the whole ELF image must be... hack, hack...
Yep, that works too!
So how does that alternative patch look?