On Tue, 28 May 2013 12:46:34 +0200, Mark Wielaard wrote:
If it is just for one or two variables, lets just do like
sysvhash_entrysize. Add any variables used directly to the ebl struct in
libebl/libeblP.h. Initialize them to something sane in the
libebl/eblopenbackend.c and let any backends that want to override the
value in their init function.
Does that make sense for your use case?
Yes, I see the EBLHOOKVAR macro not only is not useful but it even has wrong
side-effect:
$ nm ./backends/libebl_x86_64.so|grep frame_state_nregs
00000000002110e0 b i386_frame_state_nregs
00000000002110d8 b x86_64_frame_state_nregs
These global variables are not used anywhere and I never intended to create
them.
EBLHOOK macro purpose is to create prototypes for functions but that is not
useful for variables.
OK, this patch is dropped and I will remove its use from the rest of the
series.
Thanks,
Jan