On Thu, Oct 15, 2015 at 1:18 PM, Roland McGrath <roland(a)hack.frob.com>
wrote:
> +inline static int
static inline int
Fixed.
> +file_matches (Dwarf_Files * files, size_t idx,
Gratuitous space after * there.
I found most other places do not have space after "*".
So I removed the extra space here to be consistent. :-)
> + const char *lastfile, size_t match_file_len,
> + const char *match_file, bool *lastfile_matches)
When what should be a local function has several parameters like this to
replace what should be the closed-over variables, I think it's clearer to
put all those parameters first, before the real parameters to the function.
Changed, to have input read-only parameter first, followed by old
parameters and then output parameters.
Please review the new attached 0002*patch file again.
Thanks.