On 08/22/2012 12:22 PM, Roland McGrath wrote:
> + /* Can't happen */
Period and two spaces at the end of a sentence.
> + default:
> + *setname = NULL;
> + return 0;
Bad indentation.
> --- a/libebl/ChangeLog
> +++ b/libebl/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-08-21 Jeff Kenton<jkenton(a)tilera.com>
> +
> + * eblopenbackend.c (machines): Add tilegx.
> +
> +
> 2011-06-26 Mark Wielaard<mjw(a)redhat.com>
One excess blank line there.
> --- a/src/ChangeLog
> +++ b/src/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-08-21 Jeff Kenton<jkenton(a)tilera.com>
> +
> + * elflint.c (valid_e_machine): Add EM_TILEGX and EM_TILEPRO.
> +
> +
> 2012-08-16 Mark Wielaard<mjw(a)redhat.com>
Same here.
Looks fine to me other than those nits.
Thanks,
Roland
_______________________________________________
elfutils-devel mailing list
elfutils-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/elfutils-devel
Fixed and attached. Thanks.
--jeff kenton