On 08/16/2012 01:49 PM, Roland McGrath wrote:
We don't touch elf.h directly, we only copy it verbatim from
glibc.
I've done that update.
Your changes need ChangeLog entries.
You don't need to quote the contribution agreement in your commit message,
just the -s (Signed-off-by line) is enough.
Your new files have the wrong copyright terms.
Please follow the model of the existing files in the git repository.
Please cite 'make check' results on a native build.
You also need to add tilegx cases to run-allregs.sh and perhaps others.
In backends/*_regs.c note how we have mostly avoided tables of string
pointers, because these necessitate dynamic relocs for the pointers.
That's not a problem with string constants used directly in code.
Thanks,
Roland
1. Done. New patch attached.
2. Changelog:
backends/
*Makefile.am: added tilegx processor.
*tilegx_corenote.c: new file.
*tilegx_regs.c: new file.
*tilegx_reloc.def: new file.
*tilegx_init.c: new file.
*tilegx_retval.c: new file.
*tilegx_symbol.c: new file.
libebl/
*eblopenbackend.c: added tilegx processor.
src/
*elflint.c: added tilegx processor.
tests/
*run-allregs.sh: added testfile60 for tilegx processor.
*testfile60.bz2: new file.
3. make check results:
Several errors of this type:
I am discussing this problem in another email thread with Mark
Wielaard. Our tool chain is producing .so files with data that elflint
doesn't expect:
3. elflint.c, at line 954, generates an error:
section [36] '.symtab': _GLOBAL_OFFSET_TABLE_ symbol value 0x20c28
does not match .got.plt section address 0x20cb8
for many of the *.so files it checks. This is because the *.so
intentionally points to ".got" rather than ".got.plt". Our gcc guy
doesn't believe this is an error.
section [36] '.symtab': _GLOBAL_OFFSET_TABLE_ symbol value 0x20c28 does
not match .got.plt section address 0x20cb8
*** failure in ../src/elflint --quiet --gnu-ld ../backends/libebl_x86_64.so
FAIL: run-elflint-self.sh
=============================================
1 of 88 tests failed
Please report to
https://bugzilla.redhat.com/
=============================================
--jeff kenton <jkenton(a)tilera.com>