On Wed, 07 Mar 2012 23:46:58 +0000, SB (Sérgio) wrote:
Hi,
I'd like that someone sponsor me, to reinsert smb4k in Fedora.
I have follow upstream and update the package to last stable version.
The .spec is just an update of previous version, so should be easy to
review , or is already reviewed .
https://bugzilla.redhat.com/show_bug.cgi?id=799651
The package doesn't follow the latest packaging guidelines yet, however.
Could you re-examine sections
* BuildRoot tag
* Explicit Requires
* Requiring Base Package
* File Permissions
at
https://fedoraproject.org/wiki/Packaging:Guidelines ?
Further items:
%setup -q
# Fix pt translation
pushd po/pt/
mv pt.po smb4k.po
popd
When was that fix introduced? And is it still necessary?
The comment could be more verbose.
%files devel
%defattr(-,root,root,-)
# %{_kde4_includedir}/smb4k*.h
%{_libdir}/libsmb4kc*.so
Why is the headers dir not included? The -devel package explicitly
refers to "include files". Where are they?