-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On Tue, 2018-02-13 at 10:36 +0000, Daniel P. Berrangé wrote:
On Tue, Feb 13, 2018 at 10:18:05AM +0000, Richard W.M. Jones wrote:
>
> My build of american-fuzzy-lop fails because clang doesn't
> understand the ‘-mcet -fcf-protection’ flags which seem to be
> added by RPM.
>
> clang -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-
> gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
> -fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection
> -Wall -D_FORTIFY_SOURCE=2 -g -Wno-pointer-sign
> -DAFL_PATH=\"/usr/lib64/afl\" -DBIN_PATH=\"/usr/bin\"
> -DVERSION=\"2.52b\" afl-clang-fast.c -o ../afl-clang-fast
> clang-6.0: error: unknown argument: '-mcet'
> clang-6.0: error: unknown argument: '-fcf-protection'
>
> (
https://koji.fedoraproject.org/koji/taskinfo?taskID=25000571)
>
> This suggests a bug in our RPM configuration.
Not much more info about what these flags do, but the change was recorded
here with an opaque "Intel says we need this" rationale:
https://bugzilla.redhat.com/show_bug.cgi?id=1538725
redhat-rpm-config flags have usually been compatible with both gcc and
clang, so if there's no newer clang that supports this, it feels like
we've a few options
1. Have the RPM spec for apps using clang filter these flags out of
the RPM cflags.
2. Revert the change in redhat-rpm-config so we're compatible with
clang
3. Provide a second macro in redhat-rpm-config that is the cut down
set of cflags which still work with clang, that apps can opt for.
As long as it doesn't break builds, I don't think we need this separation. If
clang is simply ignoring flags, let it do that 😉
- --
- -Igor Gnatenko
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlqD3YYACgkQaVcUvRu8
X0xrhw/+IXyGgcnNd3vJoQJJr25sg23FKP/Y4iPDEFf1Le96/GM1FiFyD5vFgHsS
Y5n8MQwzMpW/1QX/T8x2+EomQdnkXZG0EDG6smuOGKeEENiuAjuujULyrTQWEpr1
UychOFEdn6ZJJTUsqKn4LOlCwAvuUdvrgT/B3JyF5iFaKV6VTU76vDjoa4HjkyQY
lohRWFGNamb5fTpfP2it6CcDCOBV3ABN7TVAUd/v1sXP+FjrXBVk2DBZIeoDs52W
BP+ftXQaEsgdb6RN5IStvQ4d4TOcmEjun3bPzUU8w2ldPGJfJ6QPyrj0Tvye18XC
gDrVbjKvFQdZAFNYWWO5SEakb3ZWgzKzUHAi2MOZNcA4D+hgny0E+uPPdq5O6qnc
KlFM7QZTpQO9oZAqvn/2EDI10XJdzXPVVtp992Vbgm01nDuVhr6XeaKbyEnBErk5
pE1/voR5Vw8Cx5nu+yFBrn6VPSQVJFjs+iY5DOH0jS2WAF9J9npIsTl0FdpsaaWC
Uzu6Q3KwQs4TEoF5Xn/Z98gt/tUb5QK2meQfUz55Arm1x4Zp5KigaHUv99lpBP5n
sixBJS54rorf0LlK+Fi6jglrJAIdXMCvlJ4NIUms5gN6OCaoshO5baKu7vCv26uc
44yvhaVupmYJDwyB/UG6KuxsCPLyzQ7HEMRUhNfXJ++QYkCVPAM=
=frLg
-----END PGP SIGNATURE-----